Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discordant expected dup removal - only apply to replicates pass call rate & contamination #324

Closed
1teaspoon opened this issue Sep 19, 2024 · 1 comment · Fixed by #327 or #345
Closed
Assignees

Comments

@1teaspoon
Copy link
Contributor

In the example below, since SB745670_PB84781_F05 is below call rate filter, sample SB745670_PB84781_G01 should be kept for subject level analysis. Unless they are both pass call rate & contamination filter, both replicates should be removed.
image

@jaamarks
Copy link
Collaborator

jaamarks commented Oct 2, 2024

update

We are still experiencing an issue with the retention of expected replicates when one of the samples fails the call rate filters. Specifically, if we have two samples that are expected replicates and one does not pass the call rate filter, the other sample that does pass should still be retained and proceed to subject-level qc.

This did not happen in the case below though. We would expect to retain SB745670_PB84781_G01 since its counterpart SB745670_PB84781_F05 had a low call rate.

Sample_ID Group_By_Subject_ID Project Case/Control_Status Internal Control Number Samples Per Subject Replicate IDs Sample Excluded from QC Sample Used in Subject Analysis Subject Removed Sample Pass QC Low Call Rate
SB745670_PB84781_G01 I-0000618499 GP0385-CI21 Control FALSE 2 SB745670_PB84781_F05|SB745670_PB84781_G01 FALSE FALSE TRUE FALSE FALSE
SB745670_PB84781_F05 I-0000618499 GP0385-CI21 Control FALSE 2 SB745670_PB84781_F05|SB745670_PB84781_G01 FALSE FALSE TRUE FALSE TRUE

jaamarks added a commit that referenced this issue Oct 9, 2024
…ment

bugfix: cleaner data handling and improved logic for `sample_qc_table.py` (issue #324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants