Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make attending authors and primary attendees configurable #4584

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Dec 6, 2023

Whether attending authors or primary attendees are required can now be configured through the dictionary.

Closes AB#988

User changes

  • Depending on dictionary settings, attending authors or primary attendees may now no longer be required.

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
    Add something like the following under fields.reports in the dictionary:
      reportPeople:
        optionalAttendingAuthor: false
        optionalPrimaryAdvisor: false
        optionalPrimaryPrincipal: true
        attendeeGroups:
          - label: Linguists
            filter:
              orgUuid: 70193ee9-05b4-4aac-80b5-75609825db9f
    
    (note that the pre-existing attendeeGroups setting has moved to be under the new reportPeople settings)
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten force-pushed the AB-1003-1004-make-minAttendingAuthors-and-primaryAttendees-configurable branch 2 times, most recently from ec54bab to 662a77f Compare December 6, 2023 12:40
@gjvoosten gjvoosten marked this pull request as ready for review December 6, 2023 13:15
@gjvoosten gjvoosten force-pushed the AB-1003-1004-make-minAttendingAuthors-and-primaryAttendees-configurable branch 4 times, most recently from 4212cbe to 774c24c Compare December 13, 2023 07:39
@gjvoosten gjvoosten force-pushed the AB-1003-1004-make-minAttendingAuthors-and-primaryAttendees-configurable branch from 774c24c to 051c931 Compare December 20, 2023 15:54
@gjvoosten gjvoosten force-pushed the AB-1003-1004-make-minAttendingAuthors-and-primaryAttendees-configurable branch from 051c931 to 62b1bf8 Compare December 21, 2023 16:53
@midmarch midmarch merged commit d2f0ad5 into main Jan 10, 2024
23 checks passed
@midmarch midmarch deleted the AB-1003-1004-make-minAttendingAuthors-and-primaryAttendees-configurable branch January 10, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants