dask: Deal with some (but not all) TODODASK placeolders #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
requested changes
Jan 30, 2023
There was a problem hiding this comment.
Otherwise all good, though as-is one of the previously-passing test methods errors because of the name change for _is_numeric_dtype. This should be all that is needed to fix it:
diff --git a/cf/test/test_Data_utils.py b/cf/test/test_Data_utils.py
index 414e7a04c..aa5f53026 100644
--- a/cf/test/test_Data_utils.py
+++ b/cf/test/test_Data_utils.py
@@ -71,7 +71,7 @@ class DataUtilsTest(unittest.TestCase):
def test_Data_Utils__is_numeric_dtype(self):
"""TODO."""
- _is_numeric_dtype = cf.data.utils._is_numeric_dtype
+ _is_numeric_dtype = cf.data.utils.is_numeric_dtype
for a in [
np.array([0, 1, 2]),
np.array([False, True, True]),
|
Good spot, thanks. Fixed in d698e7d |
sadielbartholomew
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with some (but not all) TODODASK placeolders. The ones remaining either need to stay for versions after 3.14.0, or else will be dealt with in another PR for 3.14.0.