Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAMA to Dask: address TODODASK items #433

Closed
sadielbartholomew opened this issue Aug 11, 2022 · 1 comment · Fixed by #539, #540 or #541
Closed

LAMA to Dask: address TODODASK items #433

sadielbartholomew opened this issue Aug 11, 2022 · 1 comment · Fixed by #539, #540 or #541
Labels
dask Relating to the use of Dask
Milestone

Comments

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Aug 11, 2022

Whilst migrating the Data object itself from LAMA to Dask (notably migrating the methods in #295), we left various TODODASK markers. This is a bumper issue to record that these should be addressed for us to have considered #182 closable (addressing may in some cases mean converting to a standard TODO if that feels appropriate).

At the time of commenting, we have ~250 cases to resolve:

$ pwd
/home/sadie/cf-python/cf
$ git grep "TODODASK" | wc -l
253

These have been classified as one of the following via a TODODASK<optional marker> searchable form (copied from #437 (comment)):

  • TODODASKVER for cases of placeholders for the final version for the release with the Dask migration which can now be sorted easily in a targeted way via a single sed or similar command;
  • TODODASKDOCS for required docstring or documentation updates;
  • TODODASKMSG for use-facing messages e.g. error messages;
  • TODODASKAPI for API changes or considerations (potentially to bump to the release after Dask as per recent versioning discussions);
  • TODODASKDEPR for anything deprecation related;
  • anything else presently left as-is with TODODASK (miscellaneous etc.), these probably being the most meatly/difficult TODOs of all.

(Note that cases of one particular item can be found via something like (without the final pipe to wc -l):

$ git grep "TODODASK" | grep -v "TODODASKVER" | grep -v "TODODASKDOCS" | grep -v "TODODASKMSG" | wc -l
45

)

Please add any notes and discussion points regarding these to this thread.

@davidhassell
Copy link
Collaborator

These items now dealt with, apart from the ones we want to leave there for later. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Relating to the use of Dask
Projects
None yet
2 participants