-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAMA to Dask: TODO tag cataloguing & further tidy #437
LAMA to Dask: TODO tag cataloguing & further tidy #437
Conversation
Specifically, applied command: find . -type f | xargs sed -i 's/\.\. versionadded:: TODODASK/\.\. versionadded:: TODODASKVER/g'
Specifically, applied command: find . -type f | xargs sed -i 's/version TODODASK/version TODODASKVER/g'
Targets 'version="TODODASK"' w/ command form stated in prev. commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sadie. This'll make things easier, and good spot on the Exception
-> ValueError
item.
Thanks for reviewing David. I am about to push a few more 'TODO' tag identifier updates (sorry I should have mentioned that it might be best to review at the end, keeping this in draft form) but they are all quite trivial as with the rest of this PR, so if you don't think it necessary there's no need to review the few extra commits I'll push in a moment. |
Ah - sorry for being slightly precipitous. Good idea to merge whenever you're ready. |
My fault in fact, sorry, I opened this in non-draft form by mistake so you were notified pre-maturely. Should have commented as such.
Thanks, will do. |
@@ -2256,6 +2253,9 @@ def can_compute(self, functions=None, log_levels=None, override=False): | |||
False. | |||
|
|||
""" | |||
# TODODASKAPI - this method is premature - needs thinking about as part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These methods marked TODODASKAPI
are API-related and therefore can probably be bumped to be considered instead as part of work to do after the Dask migration release, i.e. tranform to plain TODO
s that we can keep track of via a dedicated Issue. I'll note that on the main Issue #433.
Tidies the
lama-to-dask
branch further in the following ways:TODODASK
markers left over from development work towards Replace LAMA with Dask to parallelise cf.Data #182 to aid with LAMA to Dask: addressTODODASK
items #433, because some are related and also some trivial, so it is very useful going forward to group and distinguish these (without stoppingTODODASK
overall from being searchable), notably to use:TODODASKVER
for cases of placeholders for the final version for the release with the Dask migration which can now be sorted easily in a targeted way via a singlesed
or similar command;TODODASKDOCS
for required docstring or documentation updates;TODODASKMSG
for use-facing messages e.g. error messages;TODODASKAPI
for API changes or considerations (potentially to bump to the release after Dask as per recent versioning discussions);TODODASKDEPR
for anything deprecation related;TODODASK
(miscellaneous etc.), these probably being the most meatly/difficult TODOs of all.np.ma.masked
tocf.masked
in the current docstring examples for consistency;See individual commits for separate work on each of the above.