Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtc/develop: update from EMC 2019/11/27 #9

Merged
merged 14 commits into from
Dec 3, 2019
Merged

dtc/develop: update from EMC 2019/11/27 #9

merged 14 commits into from
Dec 3, 2019

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 27, 2019 •
edited
Loading

This PR contains:

  • updates from EMC's main branch (develop)
  • updates for CCPP regression tests to match the changes from EMC
  • add flag '-Wall' to DEBUG flags for GNU compiler in conf/configure.fv3.*.gnu
  • update FMS to point to the newly created 2019.01 tag in the NOAA-GFDL repository (based on the master branch in this repository) - @DusanJovic-NOAA, for your information
  • move cheyenne.intel tests regression tests from tests/rt.conf to tests/rt_intel.conf to separate EMC regression testing from NCAR regression testing (we already have tests/rt_gnu.conf for cheyenne.gnu); change default queue on Cheyenne from premium to economy

Associated PRs see below, for regression testing see #9.

junwang-noaa and others added 6 commits November 15, 2019 15:42
@junwang-noaa
Bugfixes and gfs physics update (#9)
287b631 
* Squashed commit from JessicaMeixner-NOAA/ww3update branch
* remove fv3_regional_c768 test on cray
* remove jobs with exclusive nodes on hera and jet
* add ww3 files in rt.sh
* add README.md and reset tasks for rt.sh test fv3_gfdlmprad
* comment out rt.sh fv3_wrtGauss_nemsio_c768 as it takes too long to run
* remove weightfiles for comparison in fv3-ww3 tests
* update regression test log files from dell and cray
* update regression log files on hera
* update fv3atm repo to NOAA-EMC
@BinLiu-NOAA @DusanJovic-NOAA
The HAFS related developments for the write_grid_component (#10)
dca7a75 
* Enable outputting a grid (regional_latlon, rotated_latlon, or lambert_conformal) larger than the native computation grid for the regional or nested domain/tile.

* Enable writing out the output on the native computation grid directly without any interpolation for the regional or nested domain/tile.

* Also the missing value in physics bundle is changed from real(kind_phys) to real in io/FV3GFS_io.F90 as the file could be compiled in 32bit real or 64bit real.
@climbfuji
Update submodule pointer for WW3 to match EMC
4227033
@climbfuji
tests/fv3_conf/ccpp_gsd_sar_run.IN: bugfix, correct path to CCPP libr…
49d5095 
…aries for dynamic build
@climbfuji
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
defe5fa 
…r-model into HEAD
@climbfuji
Update of CCPP regression test configurations to reflect changes from…
2deb2e1 
… EMC
This was referenced Nov 29, 2019
Merged
Merged
Merged
Merged
@climbfuji
Copy link
Collaborator Author

Associated PRs:

NCAR/ccpp-framework#243
NCAR/ccpp-physics#360
NCAR/GFDL_atmos_cubed_sphere#6
NCAR/fv3atm#11
#9

@climbfuji
Copy link
Collaborator Author

Regression testing on hera/intel using rt.conf against original EMC baseline: the following tests fail because of missing baselines (ok, because I added the tests in this commit):

fv3_gfdlmprad_repro
fv3_ccpp_gfdlmprad_repro
fv3_ccpp_gfdlmprad_prod
fv3_ccpp_wrtGauss_nemsio_c768_prod (only the new output file for WW3 is missing)

The following tests fail because of updates to the GSD suite that are not in the codebase EMC used to create the baseline:

fv3_ccpp_gsd_repro
fv3_ccpp_gsd_prod

--> OK

rt_full.log
rt_135_fv3_ccpp_gsd_prod.log
rt_114_fv3_ccpp_wrtGauss_nemsio_c768_prod.log
rt_113_fv3_ccpp_gfdlmprad_prod.log
rt_101_fv3_ccpp_gsd_repro.log
rt_81_fv3_ccpp_gfdlmprad_repro.log
rt_55_fv3_gfdlmprad_repro.log

@climbfuji climbfuji force-pushed the dtc_develop_udpate_from_emc_20191127 branch from f32c931 to 20d3b98 Compare December 2, 2019 18:30
@climbfuji
Copy link
Collaborator Author

Regression testing on hera/intel using rt_ccpp_caps.conf: all tests pass (first create, then verify).

rt_ccpp_caps_verify.log
rt_ccpp_caps_create.log

@climbfuji
Copy link
Collaborator Author

Regression testing on hera/intel using rt_ccpp_gsd.conf: all tests pass (first create, then verify). In particular, the CCPP dynamic version of fv3_ccpp_gsd_drag_suite is now b4b identical with the CCPP static version, and the newly added fv3_ccpp_gsd_sar test now runs (and is b4b identical) as well.

rt_ccpp_gsd_verify.log
rt_ccpp_gsd_create.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 2, 2019 •
edited
Loading

Regression testing on hera/intel using rt_ccpp_dtc.conf: all tests pass (first create, then verify).

rt_ccpp_dtc_verify.log
rt_ccpp_dtc_create.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 2, 2019 •
edited
Loading

Regression testing on hera/intel using rt.conf to create new baseline (DTC maintains its own regression test baseline directory) and verify against it (after copying to the correct regression test baseline directory): all pass.

rt_full_create.log
rt_full_verify.log

@climbfuji climbfuji marked this pull request as ready for review December 2, 2019 18:35
@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne/gnu using rt_gnu.conf: all tests pass (first create, then copy new baseline to regression test baseline directory /glade/p/ral/jntp/GMTB/NEMSfv3gfs/RT/trunk-20191121/GNU, then verify against it).

rt_gnu_verify.log
rt_gnu_create.log

grantfirl
grantfirl approved these changes Dec 2, 2019
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@climbfuji
Copy link
Collaborator Author

NEMSCompsetRun on hera/intel: all pass.

NEMSCompsetRun.log

@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne/intel using rt_intel.conf: all tests pass (first create, then copy new baseline to regression test baseline directory /glade/p/ral/jntp/GMTB/NEMSfv3gfs/RT/trunk-20191121/INTEL, then verify against it).

rt_intel_create.log
rt_intel_verify.log

@climbfuji climbfuji merged commit 9ac4703 into NCAR:dtc/develop Dec 3, 2019
@climbfuji climbfuji mentioned this pull request Dec 8, 2019
Merged
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Apr 3, 2020
@DomHeinzeller
Merge pull request NCAR#9 from climbfuji/update_submodule_pointer
108db8c 
Update submodule pointer for fv3atm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl grantfirl approved these changes

@tanyasmirnova tanyasmirnova tanyasmirnova approved these changes

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@climbfuji @grantfirl @tanyasmirnova @junwang-noaa @BinLiu-NOAA