dtc/develop: update from EMC 2019/11/27 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates in gfdlmp to reduce cold bias in lower level
This was referenced Nov 29, 2019
This was referenced Nov 29, 2019
…le zl, comment out unused variables
…d tendency limiter, bugfix for calculating number concentrations
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
mdtoy
approved these changes
Dec 2, 2019
tanyasmirnova
approved these changes
Dec 2, 2019
grantfirl
reviewed
Dec 2, 2019
| @@ -661,6 +660,17 @@ subroutine drag_suite_run( & | |||
| enddo | |||
| enddo | |||
| ! | |||
| ! calculate mid-layer height (zl), interface height (zq), and layer depth (dz2). | |||
There was a problem hiding this comment.
Not a big deal, but this comment no longer reflects what the code is doing.
There was a problem hiding this comment.
I actually left it on purpose (and just commented out the parts that are no longer calculated, zq and dz2) in case Mike wants to put it back later.
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
Add metadata for three constants that are required for the changes in PR NCAR#525. The motivation behind these changes is that physical parameterizations should receive constants (e.g. gravitational acceleration) from the host model via the argument list instead of importing them from some Fortran module or defining them locally. This ensures consistency and enhances interoperability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Associated PRs see below, for regression testing see NCAR/ufs-weather-model#9.