configuration files for Ferrier-Aligo MP scheme #1
Conversation
mzhangw
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
|
@mzhangw Could you please add links to associated PRs in a comment (for all PRs)? This makes it easier for reviewers to follow changes and it documents the work better. Also, choose one of the PRs to try to describe the work done as completely as you can to supplement reviewers' understanding of the changes (so we don't just rely on reading code). The RT logs should be uploaded to the same PR where you have your more complete description. Thanks! |
| @@ -0,0 +1,25 @@ | |||
| ############################################################################### | |||
| # | |||
| # FV3 CCPP regional c768 test | |||
There was a problem hiding this comment.
You may want to update the description to mention that this is testing the Ferrier-Aligo scheme.
tests/rt_ccpp_HAFS.conf
Outdated
| COMPILE | CCPP=Y REPRO=Y | standard | hera.intel | | | ||
| # Run tests, input data currently only available on Theia | ||
| #RUN | fv3_ccpp_ferhires | standard | | | | ||
| RUN | fv3_ccpp_regional_c768_FA_update_moist | standard | | | |
There was a problem hiding this comment.
So, for the merge, the new fv3_ccpp_regional_c768_FA_update_moist test should be added to a different rt*.conf? The CCPP section of rt.conf?
There was a problem hiding this comment.
This should be added to rt_ccpp_dtc.conf for the time being, no new rt_ccpp_HAFS.conf please.
| cp @[RTPWD]/FV3_input_data/DETAMPNEW_DATA* . | ||
| cp @[RTPWD]/FV3_input_data/*grb . | ||
| cp @[RTPWD]/FV3_input_data/*_table . | ||
| cp /home/Man.Zhang/diag_table_FA diag_table |
There was a problem hiding this comment.
This is pointing to Man's personal directory. Should it point somewhere else?
There was a problem hiding this comment.
This should be staged in the gmtb area, independent of a user, until it gets moved into the operational regression test baseline maintained by EMC.
| pre_rad = .false. | ||
| ncld = 5 | ||
| imp_physics = 15 | ||
| spec_adv = .true. |
There was a problem hiding this comment.
Are spec_adv and RHGRD the only new namelist variables for F-A?
2. add lradar in NML for dbz OUTPUT 3. change shal_cnv to .false. for explicit simulation in regional C768 configuration.
… into HAFS_fer_hires
|
You have suggested using rt_ccpp_dtc.conf . It is OK with me. but no
benchmark is necessary considering EMC developers are still tuning now.
I use these to test:
# Compile with CCPP - dynamic mode
COMPILE | CCPP=Y REPRO=Y | standard | hera.intel |
|
# Run tests, input data currently only available on Theia
RUN | fv3_ccpp_regional_c768_FA_update_moist | standard |
|
…On Fri, Nov 22, 2019 at 2:25 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** approved this pull request.
I noticed that the new regression test is not added to any regression test
configuration (rt*.conf), hence it will not be exercised. Please add it to
the appropriate rt*.conf or let me know where you want to add it and I will
do that in one of the next PRs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AG7TW2S4SKMS6CBDR7B2473QVBE35A5CNFSM4JMFYV5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXI6MY#pullrequestreview-321818419>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TW2QHACHLRN3EHJJDXN3QVBE35ANCNFSM4JMFYV5A>
.
|
|
Ok, I will add this in one of the next PRs. Please no more changes except the tiny removal of comments to avoid having to rerun the tests. If addressing Grant's changes requires rerunning the tests, then we don't have any other choice, though. |
…anges_from_gmtb_develop_as_of_20191016 Update ufs-weather-model/develop with changes from gmtb/develop as of 2019/10/16
…cs_timestep_for_spinup Update submodule pointer for FV3 2019/12/12
Updates for hwrf_sfc_PR from Dom
…y#524) * point to Jun fv3atm personal fork * add CDEPS submodule * add building instructions * fix issues that came from building * builds CDEPS targets * missed w3nco dep * cleanup use of FoX and remove redundant library links in components * Add 3 files generated by genf90.pl to the CDEPS-interface/ufs directory. (NCAR#1) * remove dependency on genf90.pl for CDEPS/share * remove FoX (NCAR#2) remove FoX dependency building and use ESMF Config instead. Co-authored-by: Jun Wang <[email protected]> Co-authored-by: BinLi-NOAA <[email protected]> Co-authored-by: Brian Curtis <[email protected]>
This PR includes configuration files to run Ferrier-Aligo MP scheme with c768 regional setup.
The associated PRs are:
NCAR/GFDL_atmos_cubed_sphere#5
NCAR/fv3atm#2
NCAR/ccpp-physics#352 (originally, now replaced by NCAR/ccpp-physics#358)