Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement PR for "Implement Ferrier-Aligo MP scheme in CCPP-Physics" from @mzhangw (squashed commits) #358

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Replacement PR for "Implement Ferrier-Aligo MP scheme in CCPP-Physics" from @mzhangw (squashed commits) #358

merged 1 commit into from
Nov 22, 2019

Conversation

climbfuji
Copy link
Collaborator

This PR is a replacement for #352 from @mzhangw in which the commit history was squashed into one clean commit.

It adds the Ferrier-Aligo microphysics scheme and make corresponding changes in interstitial and radiation code. The code in this PR is identical to that in the original PR #352.

The original PR was tested with several other commits:
NCAR/GFDL_atmos_cubed_sphere#5
NCAR/fv3atm#2
NCAR/ufs-weather-model#1

@climbfuji
From @mzhangw: add Ferrier-Aligo microphysics scheme and make corresp…
27c21db 
…onding changes in interstitial and radiation code
@climbfuji climbfuji mentioned this pull request Nov 22, 2019
Closed
@mzhangw mzhangw mentioned this pull request Nov 22, 2019
Merged
@climbfuji
Copy link
Collaborator Author 

$ diff ccpp-physics-fa-from-man/ ccpp-physics-dtc-develop-merge-fa/
Common subdirectories: ccpp-physics-fa-from-man/.git and ccpp-physics-dtc-develop-merge-fa/.git
Common subdirectories: ccpp-physics-fa-from-man/physics and ccpp-physics-dtc-develop-merge-fa/physics

@climbfuji climbfuji requested a review from mzhangw November 22, 2019 23:00
mzhangw
mzhangw approved these changes Nov 22, 2019
View reviewed changes
Copy link
Collaborator

@mzhangw mzhangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@climbfuji climbfuji merged commit ed8d6b9 into NCAR:dtc/develop Nov 22, 2019
@climbfuji climbfuji deleted the man_fa_squashed branch June 27, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzhangw mzhangw mzhangw approved these changes

@grantfirl grantfirl Awaiting requested review from grantfirl

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@climbfuji @mzhangw