Update history string objects #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
requested changes
Jul 7, 2024
The ADF was missing the correct call for baseline history strings, this fix will make sure to grab the correct strings.
|
@nusbaume I got your suggestions done, but it looks like we still have some issues with the new history string implementation; the baseline history strings were not being brought over from the yaml file correctly. I have a quick addition in |
nusbaume
approved these changes
Jul 11, 2024
justin-richling
added a commit
to justin-richling/ADF
that referenced
this pull request
Jul 11, 2024
Bring in changes from PR NCAR#316 Update time fix for old CESM time series files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the history string objects in
adf_info.py:clean up naming of history string variables
Make baseline history info more robust; set default if not provided
Give full dictionary of test and baseline case(s) history string lists to adf object
Update
tape_recorder.pyfor new history string format:Closes #315