Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tape Recorder plots failing after recent history string update #315

Closed
justin-richling opened this issue Jul 1, 2024 · 0 comments · Fixed by #316
Closed

Tape Recorder plots failing after recent history string update #315

justin-richling opened this issue Jul 1, 2024 · 0 comments · Fixed by #316
Labels
bug Something isn't working

Comments

@justin-richling
Copy link
Collaborator

ADF run type

Model vs. Model

What happened?

After PR #310 the Tape Recorder plots are failing due to incorrect ADF object history string returns.

File "/glade/work/richling/ADF/ADF/lib/../scripts/plotting/tape_recorder.py", line 40, in tape_recorder
    hist_str = adfobj.hist_string
  File "/glade/work/richling/ADF/ADF/lib/adf_info.py", line 636, in hist_string
    return self.__hist_str
AttributeError: 'AdfDiag' object has no attribute '_AdfInfo__hist_str'

ADF Hash you are using

c715fc1

What machine were you running the ADF on?

CISL machine

What python environment were you using?

NPL (CISL machines only)

Extra info

I have a fix, will create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant