Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sFTP for Postgres #554

Merged
merged 2 commits into from
May 7, 2019
Merged

Fix sFTP for Postgres #554

merged 2 commits into from
May 7, 2019

Conversation

talavis
Copy link
Contributor

@talavis talavis commented May 6, 2019

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Updated the generate sFTP credentials functions to use digest() instead of SHA2, including a workaround to remove the prefix '\x' from the generated hash.

Also removes the non-functional sFTP tab from the dataset admin page.

@norling
Copy link
Contributor

norling commented May 7, 2019

You can cast the hash to a hex value (removing the prefix) with passwd_hash = fn.encode(fn.digest(password, 'sha256'), 'hex'). Looks good otherwise!

@talavis talavis force-pushed the feature/sftp-fixing branch from 360c9de to a556670 Compare May 7, 2019 05:43
@norling norling merged commit 07cea86 into develop May 7, 2019
@norling norling deleted the feature/sftp-fixing branch May 7, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants