Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/properties endpoint #530

Merged
merged 3 commits into from
Aug 26, 2024
Merged

/properties endpoint #530

merged 3 commits into from
Aug 26, 2024

Conversation

alexdunnjpl
Copy link
Contributor

@alexdunnjpl alexdunnjpl commented Aug 22, 2024

🗒️ Summary

Re-implements /products endpoint.
Implements a helper class PdsProperty, which should gradually replace the associated utility class (and be extended, if validation is determined to be required.

⚙️ Test Data and/or Report

Existing test PDS/registry-api#277 /properties endpoint (testrail C2488844) passes

re-implements #277 #322
closes #506

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, hanks @alexdunnjpl .

Regarding the test in postman, one test exists already, it just need to be unskipped.
I will do a PR for that.

@tloubrieu-jpl
Copy link
Member

However @alexdunnjpl , I am now having an error with the integration test, for example:

 Unable to parse q (product_class EQ "Product_Bundle")error message is org.antlr.v4.runtime.misc.ParseCancellationException
2024-08-22T11:35:36.904-04:00  INFO 78031 --- [nio-8081-exec-6] g.n.p.a.r.m.e.RegistryApiException       : 8a163485-e6c9-4a28-b449-660674ee58b4 UnparsableQParamException: Unable to parse the q parameter:q string value:(product_class EQ "Product_Bundle") Error message null
2024-08-22T11:35:36.904-04:00 DEBUG 78031 --- [nio-8081-exec-6] .m.m.a.ExceptionHandlerExceptionResolver : Using @ExceptionHandler gov.nasa.pds.api.registry.controllers.RegistryApiResponseEntityExceptionHandler#unparsableQParam(UnparsableQParamException, WebRequest)
2024-08-22T11:35:36.904-04:00 DEBUG 78031 --- [nio-8081-exec-6] o.s.w.s.m.m.a.HttpEntityMethodProcessor  : Using 'application/json', given [application/json] and supported [text/plain, */*, application/json]

That might be something wrong on my side, I will investigate that later. I just wanted to give you a heads up.

@tloubrieu-jpl
Copy link
Member

@alexdunnjpl , weirdly you don't have the latest version of lexer/src/main/antlr4/gov/nasa/pds/api/registry/lexer/Search.g4 in this branch which causes some tests to fail.
Do you know why ?

@alexdunnjpl
Copy link
Contributor Author

alexdunnjpl commented Aug 22, 2024

@alexdunnjpl , weirdly you don't have the latest version of lexer/src/main/antlr4/gov/nasa/pds/api/registry/lexer/Search.g4 in this branch which causes some tests to fail. Do you know why ?

@tloubrieu-jpl that's because (presumably) you're running the tests on this branch rather than the result of merging this branch into develop, and this branch doesn't have the relevant commit(s).

I've rebased on develop, so that should be sorted now.

@alexdunnjpl alexdunnjpl merged commit 9b2d227 into develop Aug 26, 2024
1 check failed
@alexdunnjpl alexdunnjpl deleted the properties-endpoint branch August 26, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, I want to know what are all the possible properties I can search against (/properties)
2 participants