-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/properties endpoint #530
/properties endpoint #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, hanks @alexdunnjpl .
Regarding the test in postman, one test exists already, it just need to be unskipped.
I will do a PR for that.
service/src/main/java/gov/nasa/pds/api/registry/model/properties/PdsProperty.java
Show resolved
Hide resolved
However @alexdunnjpl , I am now having an error with the integration test, for example:
That might be something wrong on my side, I will investigate that later. I just wanted to give you a heads up. |
@alexdunnjpl , weirdly you don't have the latest version of |
863060a
to
6f2c209
Compare
@tloubrieu-jpl that's because (presumably) you're running the tests on this branch rather than the result of merging this branch into I've rebased on develop, so that should be sorted now. |
🗒️ Summary
Re-implements /products endpoint.
Implements a helper class
PdsProperty
, which should gradually replace the associated utility class (and be extended, if validation is determined to be required.⚙️ Test Data and/or Report
Existing test
PDS/registry-api#277 /properties endpoint
(testrailC2488844
) passesre-implements #277 #322
closes #506