Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement /product-properties endpoint #322

Merged
merged 2 commits into from
May 1, 2023
Merged

Conversation

alexdunnjpl
Copy link
Contributor

@alexdunnjpl alexdunnjpl commented Apr 21, 2023

🗒️ Summary

Implements a new endpoint, /properties, which returns metadata about the searchable fields which users may use in their raw queries (q=)

This is pulled directly from the registry OpenSearch index and is thus fast and reliable.

⚙️ Test Data and/or Report

Need to add a Postman test for this, but that can wait until Monday

Postman test added in registry PR

♻️ Related Issues

Fixes #277

@alexdunnjpl alexdunnjpl requested a review from nutjob4life April 21, 2023 00:20
@alexdunnjpl
Copy link
Contributor Author

@tloubrieu-jpl is the postman collection in service/src/test/resources actually supposed to contain any tests, or just a sample set of requests? Can't tell if it's the latter or if I'm just missing something silly.

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not approving it yet because some point requires discussion.

model/swagger.yml Outdated Show resolved Hide resolved
model/swagger.yml Outdated Show resolved Hide resolved
@tloubrieu-jpl
Copy link
Member

@alexdunnjpl regarding your question on test in postman, we are having a few. They can be found in the Test tab of each request. See screenshot:
image

@alexdunnjpl
Copy link
Contributor Author

alexdunnjpl commented Apr 26, 2023

@alexdunnjpl regarding your question on test in postman, we are having a few. They can be found in the Test tab of each request. See screenshot: image

@tloubrieu-jpl where are you pulling that from? Loading the service tests file from this repository doesn't populate the tests tab with anything.

@tloubrieu-jpl
Copy link
Member

Hi @alexdunnjpl , you are right the file you are using is obsolete and should be removed. The one to use is in the registry repository https://github.com/NASA-PDS/registry/blob/main/docker/postman/postman_collection.json
Sorry about that.

@alexdunnjpl alexdunnjpl marked this pull request as ready for review April 28, 2023 20:00
@alexdunnjpl
Copy link
Contributor Author

@alexdunnjpl
Copy link
Contributor Author

Bypassing requested-changes block due to more-recent approval by other code owner

@alexdunnjpl alexdunnjpl merged commit 021c9fd into main May 1, 2023
@alexdunnjpl alexdunnjpl deleted the 277-properties-endpoint branch May 1, 2023 16:44
@alexdunnjpl alexdunnjpl mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product summary object has an incomplete "properties" set
4 participants