Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when there are multiple tests with multiple schemas/schematrons #822

Closed
jordanpadams opened this issue Oct 31, 2024 · 3 comments Β· Fixed by #826 or #835
Closed

Tests fail when there are multiple tests with multiple schemas/schematrons #822

jordanpadams opened this issue Oct 31, 2024 · 3 comments Β· Fixed by #826 or #835
Assignees
Labels

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Oct 31, 2024

Checked for duplicates

Yes - I've already checked

πŸ› Describe the bug

When I try to run back to back tests calling validate, it does not pick up later specified schemas.

πŸ•΅οΈ Expected behavior

I expected the tests to run successfully.

πŸ“œ To Reproduce

Playing around with the validate.feature file.

Scenario 1

  • Execute as is
  • First and last test fail (first test shouldn't pass)

Scenario 2

  • Comment out test 1 (github795)
  • github797 fails when it should pass. Per the error, validate is not correctly reading the LDDs (Error refers to unrecognized geom:Geometry)

Scenario 3

  • Comment out test 1 (github795)
  • Swap github795b and github797 in order
  • All tests pass

πŸ–₯ Environment Info

MacOSx

πŸ“š Version of Software Used

Latest snapshot

🩺 Test Data / Additional context

See repo

πŸ¦„ Related requirements

No response

βš™οΈ Engineering Details

No idea what is happening here. It appears validate is not properly reading/loading the GEOM LDD on the second run.

per comments below, blocked by NASA-PDS/validate#1028

πŸŽ‰ Integration & Test

No response

@jordanpadams jordanpadams added bug Something isn't working needs:triage labels Oct 31, 2024
@jordanpadams jordanpadams self-assigned this Oct 31, 2024
@github-project-automation github-project-automation bot moved this to Sprint Backlog in B15.1 Oct 31, 2024
jordanpadams added a commit that referenced this issue Oct 31, 2024
Issues with this tests when running after other. Tracked here: #822

Tests still fail but this is now expected
@al-niessner
Copy link

@jordanpadams

Your expectations are wrong. The first test fails because:
SEED 2.4' is not known to this version of validate.

While you may be using a modern information model, validate must fix NASA-PDS/validate#1028 before this test can pass. There is a block that requires loading it independent of check contents that is causing an internal error.

The second test always processes the same. However, there are tons of SEED errors there as well indicating that constant behavior is probably luck not validate good behavior.

The third, behaves different depending on 2 because one of the schematron errors becomes a warning. I do not know if this would change with SEED no longer causing the internal errors.

It is not too surprising that an internal error would leave all kinds of dodo in validate. I would prioritize fixing NASA-PDS/validate#1028 then retesting here. It also means that both validate and this StepDefs should be updated to always fail on an internal error.

@jordanpadams
Copy link
Member Author

@al-niessner copy that. let's go with that path forward. Thanks for investigating.

@github-project-automation github-project-automation bot moved this from ToDo to 🏁 Done in EN Portfolio Backlog Nov 6, 2024
@github-project-automation github-project-automation bot moved this from Sprint Backlog to 🏁 Done in B15.1 Nov 6, 2024
@jordanpadams jordanpadams reopened this Nov 6, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Done to In Progress in EN Portfolio Backlog Nov 6, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Done to In Progress in B15.1 Nov 6, 2024
@jordanpadams
Copy link
Member Author

@al-niessner unfortunately, the removing the SEED internal error noted above did not fix failures. Removing that file still causes github797 tests to fail, when all 3 tests execute successfully when run independently.

@github-project-automation github-project-automation bot moved this from In Progress to 🏁 Done in B15.1 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏁 Done
Status: 🏁 Done
2 participants