set up lint-staged and husky #788
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you so much for your contribution! |
|
@hanbyul-here - good catch. lint-staged was actually failing and swallowing the error. I should have tested the happy path better 🤦 I added the missing |
There was a problem hiding this comment.
I made a small documentation pr as a follow-up: #798
Thanks for your contribution again 🙇
I was looking to see how I could bypass the pre-commit hook and I thought, why not document it (knowing that I will need to look it up again_ I won't bypass too much I promise.)
|
I noticed that ts-check in the pre-commit stage gives an error incorrectly. |
https://github.com/NASA-IMPACT/veda-ui/releases/tag/v4.1.0 ## 🎉 Features - Experimental CMR Layer: #805 ## 🚀 Improvements - Style - Documentation - Rename critical error page: #806 - Add back button on Exploration page: #779 - Add ts, lint check for precommit hooks: #788, #809 - "skip to main" button for navigation: #808 ## 🐛 Fixes - Return datasets even when there is a dataset without summaries: #786 - Show all the datasets on Data Catalog page: #837 - Block Map user defined position fix: #784 - Geocoder centering on various projecctions: #826
closes #787
This adds husky and lint-staged to run the lint and typecheck on only staged files. I had to pin lint-staged at an older version because they dropped support of node 16 with their last major release. Testing it out things work for me. I think it should be noted that anyone modifying an existing file that already has errors will need to either fix them as part of their MR or bypass the hook.