Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user defined position setup for block maps (when compare slider is used) #784

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

hanbyul-here
Copy link
Collaborator

Close NASA-IMPACT/veda-config#352

  • While looking at this issue, I realized that we are retiring the way of using the layers for the exploration page, but not for the stories. I will make a ticket with more details, but we should consolidate how the layers/maps are used throughout the application.

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit f038321
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/6594890ff40e360008080c78
😎 Deploy Preview https://deploy-preview-784--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here
Copy link
Collaborator Author

It turned out that the ticket is already filed: #712 😅

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the issue that compare slider embeds do not keep the initial position.

I compared the embedded maps between

  1. Before: https://veda-ui.netlify.app/stories/air-quality-and-covid-19
  2. After: https://veda-ui.netlify.app/stories/air-quality-and-covid-19

@hanbyul-here hanbyul-here merged commit 67b4436 into main Jan 4, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the fix/355-zoom-compare branch January 4, 2024 14:12
sandrahoang686 added a commit that referenced this pull request Feb 13, 2024
https://github.com/NASA-IMPACT/veda-ui/releases/tag/v4.1.0

## 🎉 Features
- Experimental CMR Layer:
#805

## 🚀 Improvements
- Style 
- Documentation
- Rename critical error page:
#806
- Add back button on Exploration page:
#779
- Add ts, lint check for precommit hooks:
#788,
#809
- "skip to main" button for navigation:
#808

## 🐛 Fixes
- Return datasets even when there is a dataset without summaries:
#786
- Show all the datasets on Data Catalog page:
#837
- Block Map user defined position fix:
#784
- Geocoder centering on various projecctions:
#826
hanbyul-here added a commit that referenced this pull request Mar 25, 2024
## 🎉 Features
- Optional media attributes for layers:
#843
- Add custom javascript injection
#846
- ADR for V2 Refactor: #875

## 🚀 Improvements
- E&A imporvement. Related tickets
  - Layer select modal: #845
- Connect dataset information on layer:
#821
  - Layer info modal: #849
- Update data layer card:
#851
  - Hidden layers: #867
- Fast follow-ups: #851 ,
#862,
#863,
#860
  - PR template: #880


## 🐛 Fixes
- Return datasets even when there is a dataset without summaries:
#786
- Show all the datasets on Data Catalog page:
#837
- Block Map user defined position fix:
#784
- Geocoder centering on various projecctions:
#826
- Wording, typo: #869
#854,
#874,
- Fix yaxis labeling: #883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map compare slider component in stories does not persist zoom extent?
2 participants