Parse cookie consent form as html #1163
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you Hanbyul! This is far cleaner than what I previously had. To answer your questions: No I do not think we need to enable markdown in the title. To my knowledge there is no situation that we have discussed where we would need to accommodate that need. Additionally from a UX best practices, linking the title in this type of component would be a highly abnormal interaction pattern. I would recommend against it. Adding the prefix is a good idea. Since that is an input type that the user base is familiar with we should denote that in some fashion to avoid any confusion. |
|
I will merge this change now since some of the UI changes would need to be made because of this change. let's keep the conversation about the prefix in the og pr. |
Sounds good! |
You can find VEDA Dashboard preview link to test these changes: NASA-IMPACT/veda-config#470 ## 🎉 Features - Cookie consent component: #1163, #1165, #1127, #1177 - Stories Hub export in #1162 - Expose As Is - PageHeader, LinkElement Prop & Logo in #1184 ## 🚀 Improvements - Add docs for registry dev in #1169 - Timeline date selection centering functionality in #1181 - Deprecate old explore page, Mapbox component #1176 - Update doc with new diagrams about general architecture in #1195 - Add playwright in #1139 - Pre-select AOIs that have the "selected" prop set to true in #1215 - ## 🐛 Fixes - Check dastaset analysis exclude attribute before running analysis in #1175 - Restrict dynamic colormaps to applicable layer types in #1183 - Fix external link badge display for tools hosted under the same domain in #1192 - Escape special characters in regex expression when searching datasets in #1204 ### New Contributors * @snmln made their first contribution in #1127 * @AliceR made their first contribution in #1204
Related Ticket: {link related ticket here}
Description of Changes
We already have a mechanism to parse markdown to html bts. It is highly likely that users will try to use different markdown syntax if they see the link syntax. So here, I made parcel resolver to compile the cookieconsent form to html beforehand. I only did it for copy, but some questions are