Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories Hub export #1162

Merged
merged 12 commits into from
Oct 8, 2024
Merged

Stories Hub export #1162

merged 12 commits into from
Oct 8, 2024

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Sep 20, 2024

Related Ticket: #901

Description of Changes

  • Export StoriesHub from veda-ui

Implementation of Next will look like: https://github.com/developmentseed/next-veda-ui/blob/stories-hub/app/(datasets)/stories/hub.tsx

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 4a0eaff
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67052d3e3fc52600088183c1
😎 Deploy Preview https://deploy-preview-1162--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here changed the title Stories export Stories Hub export Sep 23, 2024
@hanbyul-here hanbyul-here marked this pull request as ready for review September 23, 2024 20:18
Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits but nonblocking - lgtm! 🙇🏼‍♀️

app/scripts/components/stories/hub/container.tsx Outdated Show resolved Hide resolved
app/scripts/components/stories/hub/hub-content.tsx Outdated Show resolved Hide resolved
@hanbyul-here hanbyul-here merged commit db8cb81 into main Oct 8, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the stories-export branch October 8, 2024 13:15
@hanbyul-here hanbyul-here mentioned this pull request Oct 29, 2024
snmln added a commit that referenced this pull request Oct 30, 2024
You can find VEDA Dashboard preview link to test these changes:
NASA-IMPACT/veda-config#470

## 🎉 Features
- Cookie consent component:
#1163,
#1165,
#1127,
#1177
- Stories Hub export in #1162
- Expose As Is - PageHeader, LinkElement Prop & Logo in
#1184
## 🚀 Improvements

- Add docs for registry dev in
#1169
- Timeline date selection centering functionality in
#1181
- Deprecate old explore page, Mapbox component
#1176
- Update doc with new diagrams about general architecture in
#1195
-  Add playwright in #1139
- Pre-select AOIs that have the "selected" prop set to true in
#1215
- 
## 🐛 Fixes
- Check dastaset analysis exclude attribute before running analysis in
#1175
- Restrict dynamic colormaps to applicable layer types in
#1183
- Fix external link badge display for tools hosted under the same domain
in #1192
- Escape special characters in regex expression when searching datasets
in #1204


### New Contributors
* @snmln made their first contribution in
#1127
* @AliceR made their first contribution in
#1204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants