Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] Bump to v5.4.0 #1074

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[RELEASE] Bump to v5.4.0 #1074

merged 1 commit into from
Jul 31, 2024

Conversation

sandrahoang686
Copy link
Collaborator

HOLD until we merge #1073

🎉 Features

🚀 Improvements

🐛 Fixes

  • 🦗

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 7229f7c
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66a8d9324cd656000898b894
😎 Deploy Preview https://deploy-preview-1074--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sandrahoang686 sandrahoang686 requested a review from aboydnw July 30, 2024 12:53
Copy link
Collaborator

@hanbyul-here hanbyul-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it 🙇 Can you add loading style fix as a bug fix ? #1073 (review)

@aboydnw
Copy link
Contributor

aboydnw commented Jul 30, 2024

I found an issue, I think this has to do with the playheads update and I didn't catch it when manually testing that ticket, sorry about that. But I don't think we can release this right now, the E&A page isn't really usable with more than one layer. Can somebody try and replicate this issue on their machine?

https://www.loom.com/share/9c0e468b5ee647d48dfd3a3d4c5a3d00?sid=830f9916-1e2f-47fb-bde8-eb0e831e0fb9

@aboydnw
Copy link
Contributor

aboydnw commented Jul 30, 2024

@hanbyul-here should the announcement text be centered? or is that just a formatting thing when configuring the banner?
image

@sandrahoang686
Copy link
Collaborator Author

Fix for Issue Anthony flagged has been addressed and merged #1077

@hanbyul-here
Copy link
Collaborator

@aboydnw It is not centered. I followed the banner style from uswds which is not centered: https://designsystem.digital.gov/components/banner/
In any case, I don't think it is worth blocking a release unless you think in a different way.

@sandrahoang686 sandrahoang686 merged commit a59bd0a into main Jul 31, 2024
8 checks passed
@sandrahoang686 sandrahoang686 deleted the release/v5.4.0 branch July 31, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants