-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] Bump to v5.4.0 #1074
[RELEASE] Bump to v5.4.0 #1074
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on it 🙇 Can you add loading style fix as a bug fix ? #1073 (review)
I found an issue, I think this has to do with the playheads update and I didn't catch it when manually testing that ticket, sorry about that. But I don't think we can release this right now, the E&A page isn't really usable with more than one layer. Can somebody try and replicate this issue on their machine? https://www.loom.com/share/9c0e468b5ee647d48dfd3a3d4c5a3d00?sid=830f9916-1e2f-47fb-bde8-eb0e831e0fb9 |
@hanbyul-here should the announcement text be centered? or is that just a formatting thing when configuring the banner? |
Fix for Issue Anthony flagged has been addressed and merged #1077 |
@aboydnw It is not centered. I followed the banner style from uswds which is not centered: https://designsystem.digital.gov/components/banner/ |
HOLD until we merge #1073
🎉 Features
🚀 Improvements
🐛 Fixes