You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style in index.html was getting ripped off on the instance level. I am not sure why this does not happen on ui level 🤔 But opening the fix since the current state is a blocker.
I debugged a bit, and everything points to the path being the issue (as it was @hanbyul-here's first impression). The rest of the CSS purging worked fine on the instance side probably because of the safeListconfig which purged all the classes which did not match the ones added to it and not because of the content array (which contains the file globs). The content array was throwing No files found from the passed PurgeCSS option 'content' in the deployment logs for the instances, but not in the veda-ui deployments. After making the paths in the PostCSS config also dynamic , the errors seem to be now gone from the deployment logs.
Thank you so much for debugging further 🙇 @dzole0311 !! I can't review this since I am the pr creator, can either of you give an approval? @dzole0311@sandrahoang686 ?
**HOLD until we merge #1073
## 🎉 Features
* Added Announcement component using USWDS Design System and adding
purge-css #1031
## 🚀 Improvements
* Add logic for tracking out-of-view Timeline playheads for E&A page
#1067
* Abstract Away Faux Modules from MapBlock Component and expose as
library component #1046
## 🐛 Fixes
- 🦗
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The style in index.html was getting ripped off on the instance level. I am not sure why this does not happen on ui level 🤔 But opening the fix since the current state is a blocker.
Please look at this pr: NASA-IMPACT/veda-config#424 to see how it looks like on the instance level.