Put a hot fix for URL search paramter *WIP* #1020
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1016
Description of Changes
Several issues are occurring with data catalog and URL manipulations. I fixed some of them in this PR and hot-glued some of them (I think we can fix them better, though).
Search
query parameter is not respected in the Data Catalog: I 'hotfix' it by reading the query parameter directly from the URL when thesearch
parameter exists in the URL.Now it shows a weird behavior of URL bouncing back to data-catalog When 'Explore data' was clicked from a data overview page, without actually bouncing the page back. 🤔
search
query parameter gets wiped out when the page is loaded: This seems to be because theCLEAR
action gets triggered on page load, which includes clearing both search terms and taxonomies. I separated these actions outtaxonomies
parameters are not being respected when clicked from data overview page.Notes
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}