Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a hot fix for URL search paramter *WIP* #1020

Closed
wants to merge 2 commits into from

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Jun 25, 2024

Related Ticket: #1016

Description of Changes

Several issues are occurring with data catalog and URL manipulations. I fixed some of them in this PR and hot-glued some of them (I think we can fix them better, though).

  1. The Search query parameter is not respected in the Data Catalog: I 'hotfix' it by reading the query parameter directly from the URL when the search parameter exists in the URL.
    Now it shows a weird behavior of URL bouncing back to data-catalog When 'Explore data' was clicked from a data overview page, without actually bouncing the page back. 🤔
  2. The search query parameter gets wiped out when the page is loaded: This seems to be because the CLEAR action gets triggered on page load, which includes clearing both search terms and taxonomies. I separated these actions out
  3. The taxonomies parameters are not being respected when clicked from data overview page.

Notes

Validation / Testing

{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 47e77de
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/667b3911e6b09c0007e6e5be
😎 Deploy Preview https://deploy-preview-1020--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here changed the title Put the hot fix for URL search paramter *WIP* Put a hot fix for URL search paramter *WIP* Jun 25, 2024
@hanbyul-here
Copy link
Collaborator Author

Closing for #1021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant