Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on a dataset tag does not filter data catalog #1016

Closed
aboydnw opened this issue Jun 25, 2024 · 2 comments
Closed

Clicking on a dataset tag does not filter data catalog #1016

aboydnw opened this issue Jun 25, 2024 · 2 comments
Labels
P2 Find a way to fix in the next few sprints regression Signifies a regression issue found during testing

Comments

@aboydnw
Copy link
Contributor

aboydnw commented Jun 25, 2024

Context

URL: https://staging.earth.gov/ghgcenter/

Blocking a release? (y/n): no

Priority: P2

  • P1 - Blocking major workflow, pull into sprint and fix now
  • P2 - Poor reflection of quality, find a way to fix in the next few sprints
  • P3 - Minor annoyance or issue, place in backlog for future consideration

Reproduction Steps

  1. Visit data catalog page
  2. Open any dataset
  3. Click on any tag/topic at the top the dataset
  4. You should be redirected to the data catalog page, filtered for the tag you clicked
  5. Notice the URL has some parameters, but it is not correctly filtering
@aboydnw aboydnw added P2 Find a way to fix in the next few sprints regression Signifies a regression issue found during testing labels Jun 25, 2024
This was referenced Jun 25, 2024
Closed
Merged
@hanbyul-here
Copy link
Collaborator

There were more problems related to query paramter generated by data-catalog. Putting those bugs here for the record.

  • The Search query parameter is not respected in the Data Catalog page
    • Type 'air' as a search term. The query parameter for 'search' gets manipulated, but when I refresh, it gets wiped out as soon as the page loads.
  • Navigating back to Data Catalog through Taxonomy Pills on the overview button does not work.
    • Click on any taxonomy pill from data overview page. taxonomy query paramter gets wiped out as soon as the page loads.

hanbyul-here added a commit that referenced this issue Jun 28, 2024
@hanbyul-here
Use different query parameter managements between data-catalog page a…
9b97013 
…nd new E&A page (#1021)

**Related Ticket:** #1016 

### Description of Changes

This PR makes Catalog View on the data-catalog page use QS-state for
query parameters, while Catalog View on the new E&A page uses Jotai. The
current Atoms related to URL management is not designed for cross-page
navigation. I drew a diagram to describe the navigation problem between
catalog page and overview page.

![Screenshot 2024-06-26 at 1 19
05 PM](https://github.com/NASA-IMPACT/veda-ui/assets/4583806/c11f216d-b3a9-4c01-b3b5-fa747d8999b1)

More context: 
We moved our query parameter management to use Jotai because of the
concerns about the mix-use of QS-State and Jotai for query parameters on
the same page. (Specifically - for the new E&A page, other parameters
are managed by Jotai). More details on this PR that initially introduced
data-catalog view to new E&A page:
#989 (comment)
In the end, we ditched the Query parameter manipulation thinking that we
don't need. (Details are in this comment:
#989 (comment))
But the bug reported #1016 made me realize that was a wrong call.


### Notes & Questions About Changes
- We need a better solution for long-term url management. 

### Validation / Testing
Navigate back and forth from data catalog to overview, from overview to
data catalog (especially through taxonomy pills on the overview page)
Navigate to the new E&A page through the 'Explore Data' button on the
overview page.


I opened a pr on ghg for testing:
US-GHG-Center/veda-config-ghg#421
@hanbyul-here
Copy link
Collaborator

Closed via https://github.com/NASA-IMPACT/veda-ui/pulls?q=is%3Apr+is%3Aclosed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Find a way to fix in the next few sprints regression Signifies a regression issue found during testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanbyul-here @aboydnw