Use VizDataset data type for block map, set a default value for interactive #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I did not benchmark yet, but I notice that BlockMap seems to fail to load more often on this PR. I am investigating it. @sandrahoang686 Update: I think this commit should fix the problem 🙇 3cfd052 |
Merged
sandrahoang686
added a commit
that referenced
this pull request
Jul 1, 2024
## What's Changed Note: This could be a patch version number. But the fix for the query parameter on the data catalog page, new E&A page, and stories hub brought a substantial change and improvement, in my opinion. And there are some other improvements we made. So I am cutting a minor version release. ## 🎉 Features 🦗 ## 🚀 Improvements * Create bug.md in #1015 * Use VizDataset data type for block map, set a default value for interactive in #1006 ## 🐛 Fixes * Fix scrollytelling projection problem in #1011 * Use different query parameter managements between data-catalog page and new E&A page in #1021 **Full Changelog**: v5.1.2...v5.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket:
Kind of related to #905 ? We would still need to revisit 'compare' - but I think we can deprecate it soon?
Description of Changes
VizDataset.resolveConfignow happens at the layer level, so I don't think we need to do it on block map level)interactive,blocks the interaction such as dragging to pan - I set the default value astrue(which was an implicit value before.)