Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Compare, Base, and Reconciled Typed interfaces to Prevent Casting #905

Open
sandrahoang686 opened this issue Mar 26, 2024 · 2 comments

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Mar 26, 2024

Description:

We need to revisit our typing as there is a ton of casting going on that is masking our bad types. Our types should be more explicit so we dont need to cast or optionally chain as much.

Acceptance Criteria:

  • Revisit Compare Types in /parcel-resolver-veda/index.d.ts
  • Revisit Reconciled Types returned from useReconcileWithStacMetadata
@sandrahoang686 sandrahoang686 changed the title Revisit Typed Interfaces and Clean Up to Prevent Casting Clean up Compare, Base, and Reconciled Typed interfaces to Prevent Casting Mar 26, 2024
@hanbyul-here
Copy link
Collaborator

Assuming this need came when we are trying to make the 'old' component ( the components that live outside of /exporation work with 'new' state management, I wonder if this will be better resolved by structuring Atoms. We are trying to reuse timelinedatasetAtoms, which is not meant to serve the other parts of the applications, and I think type mismatch happens while repurposing the timelinedatasetAtoms?

It makes sense that the types that useReconcileWithStacMetadata return might not align with our requirements elsewhere in the application. I initially thought the types defined in /parcel-resolver-veda/index.d.ts were more generalized, mainly reflecting the MDX structure. But now, I'm curious about your thoughts on how we should reshape the type. Can you detail your findings when you have a chance?

@aboydnw
Copy link
Contributor

aboydnw commented May 7, 2024

this is one of those tickets where I feel like all of the words you used are english but somehow I have no freaking clue what you said 😆

hanbyul-here added a commit that referenced this issue Jun 28, 2024
…active (#1006)

**Related Ticket:** 
Kind of related to #905 ?
We would still need to revisit 'compare' - but I think we can deprecate
it soon?

### Description of Changes
- Make BlockMap use the new type `VizDataset.` 
- Simplify some redundant logic (ex. `resolveConfig` now happens at the
layer level, so I don't think we need to do it on block map level)
- While working on it, I realized that a new flag, `interactive,` blocks
the interaction such as dragging to pan - I set the default value as
`true` (which was an implicit value before.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants