-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Compare, Base, and Reconciled Typed interfaces to Prevent Casting #905
Comments
Assuming this need came when we are trying to make the 'old' component ( the components that live outside of It makes sense that the types that |
this is one of those tickets where I feel like all of the words you used are english but somehow I have no freaking clue what you said 😆 |
…active (#1006) **Related Ticket:** Kind of related to #905 ? We would still need to revisit 'compare' - but I think we can deprecate it soon? ### Description of Changes - Make BlockMap use the new type `VizDataset.` - Simplify some redundant logic (ex. `resolveConfig` now happens at the layer level, so I don't think we need to do it on block map level) - While working on it, I realized that a new flag, `interactive,` blocks the interaction such as dragging to pan - I set the default value as `true` (which was an implicit value before.)
Description:
We need to revisit our typing as there is a ton of casting going on that is masking our bad types. Our types should be more explicit so we dont need to cast or optionally chain as much.
Acceptance Criteria:
/parcel-resolver-veda/index.d.ts
useReconcileWithStacMetadata
The text was updated successfully, but these errors were encountered: