Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict dynamic colormaps to layer types that support it #1182

Closed
j08lue opened this issue Oct 1, 2024 · 0 comments
Closed

Restrict dynamic colormaps to layer types that support it #1182

j08lue opened this issue Oct 1, 2024 · 0 comments
Assignees

Comments

@j08lue
Copy link
Contributor

j08lue commented Oct 1, 2024

Dynamic colormaps will only work for certain endpoints / services (e.g. TiTiler-based).

I guess we currently distinguish between three layer types: raster|vector|zarr.

https://github.com/NASA-IMPACT/veda-ui/blob/main/docs/content/frontmatter/layer.md

Will we need some more fine-grained distinction between server capabilities?

https://github.com/NASA-IMPACT/veda-config/blob/1250da71d5c09227938bcd614875ae85e54a1c58/datasets/cmip6-tas.data.mdx?plain=1#L30

Originally posted by @j08lue in #1102 (comment)

@dzole0311 dzole0311 self-assigned this Oct 2, 2024
dzole0311 added a commit that referenced this issue Oct 2, 2024
**Related Ticket:** #1182

### Description of Changes
1. Added util function `isRenderParamsApplicable` to handle the
exclusion of render parameters for vector datasets (for now, add more if
applicable in the future)
2. Updated logic in `reconcileQueryDataWithDataset` to prevent errors
when processing vector datasets that don't support colormaps or
rescaling

### Notes & Questions About Changes
Vector datasets should be excluded from applying dynamic colormaps.

### Validation / Testing

1. Verify that vector datasets no longer trigger errors in the
exploration view
2. Test colormap functionality on raster datasets and make sure there
are no regressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants