Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two files that fail extracting NoHit regex #140

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Conversation

FelixKrueger
Copy link

This relates to the following issue I raised this morning: MultiQC/MultiQC#1126

@ewels
Copy link
Member

ewels commented Mar 11, 2020

Thanks! Could you please put them in a subfolder that corresponds to the version of FastQ Screen that you used (like the other files in there), and preferably call them something else? ie. something related to how you generated them, or what makes them different. Because if i fix the bug then the filenames won't be so helpful 😅

@FelixKrueger
Copy link
Author

OK done. The 2 files are just 2 examples that failed.

@FelixKrueger
Copy link
Author

Oh, and thanks!

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ewels ewels merged commit 1c1ab7c into MultiQC:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants