Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for rollup 4 hashes #130

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Conversation

dmwyatt
Copy link
Contributor

@dmwyatt dmwyatt commented Apr 2, 2024

Check for rollup4-style hashes.

This addresses #114.

This addresses MrBin99#114.

It also ensures that the whitenoise immutable file test also uses the default immutable file test.

`WHITENOISE_IMMUTABLE_FILE_TEST` is intended for usage when you're not using Django’s `ManifestStaticFilesStorage`. Just because we're using `django-vite` doesn't mean that we're not using `ManifestStaticFilesStorage`, so I **think**(?) we also need the default check.
@dmwyatt dmwyatt marked this pull request as draft April 2, 2024 17:16
@dmwyatt dmwyatt changed the title Update README.md for rollup 4 hashes and handling regular static files Update README.md for rollup 4 hashes Apr 2, 2024
@dmwyatt dmwyatt marked this pull request as ready for review April 2, 2024 17:25
@Niicck
Copy link
Collaborator

Niicck commented Apr 7, 2024

Thank you!

@Niicck Niicck merged commit fee2efe into MrBin99:master Apr 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants