Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New hash pattern in Rollup 4 #114

Closed
petrprikryl opened this issue Dec 13, 2023 · 1 comment
Closed

New hash pattern in Rollup 4 #114

petrprikryl opened this issue Dec 13, 2023 · 1 comment

Comments

@petrprikryl
Copy link
Contributor

Vite 5 came with Rollup 4 which introduced new hash syntax (hex => base64). I think this should be noted in README.md:

django-vite/README.md

Line 377 in 66fce41

return re.match(r"^.+[\.\-][0-9a-f]{8,12}\..+$", url)

New regex proposal: ^.+[\.-][0-9a-zA-Z_-]{8,12}\..+$

rollup/rollup#5155
rollup/rollup#4803
dmwyatt added a commit to dmwyatt/django-vite that referenced this issue Apr 2, 2024
@dmwyatt
Update README.md for rollup 4 hashes and handling regular static files
644dd9e 
This addresses MrBin99#114.

It also ensures that the whitenoise immutable file test also uses the default immutable file test.

`WHITENOISE_IMMUTABLE_FILE_TEST` is intended for usage when you're not using Django’s `ManifestStaticFilesStorage`. Just because we're using `django-vite` doesn't mean that we're not using `ManifestStaticFilesStorage`, so I **think**(?) we also need the default check.
@dmwyatt dmwyatt mentioned this issue Apr 2, 2024
Merged
@Niicck
Copy link
Collaborator

Niicck commented Apr 7, 2024

Closed by: #130

@Niicck Niicck closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petrprikryl @Niicck