Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube Regrets 2022 - Address stat font size/spacing #9261 #9329

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

siimonevans
Copy link
Collaborator

Addresses feedback on #9261

Screenshot 2022-09-08 at 11 25 51

@siimonevans siimonevans self-assigned this Sep 8, 2022
@siimonevans siimonevans changed the title Youtube Regrets 2022 - address stat font size/spacing 9261 Youtube Regrets 2022 - Address stat font size/spacing #9261 Sep 8, 2022
Copy link
Collaborator

@tbrlpld tbrlpld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem to have adverse effects on the 2021 version

image

@siimonevans
Copy link
Collaborator Author

Waiting on other branches to get merged before picking this up, as otherwise we'll just create unnecessary conflicts.

The proposed fix is to move overrides to youtube-regrets-2022.scss rather than the shared scss partial.

@tbrlpld tbrlpld merged commit 05516f9 into main Sep 9, 2022
@tbrlpld tbrlpld deleted the feature/9261-stats-tweaks branch September 9, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants