Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YTR 2022 | Change copy on stats numbers and content surrounding #9261

Closed
3 of 4 tasks
cdanfon opened this issue Aug 23, 2022 · 3 comments
Closed
3 of 4 tasks

YTR 2022 | Change copy on stats numbers and content surrounding #9261

cdanfon opened this issue Aug 23, 2022 · 3 comments

Comments

@cdanfon
Copy link

cdanfon commented Aug 23, 2022

ACs:

  • Add title as per copy document
  • Add introduction as per copy document
  • To look as design for mobile, tablet, desktop
  • Stats to be animated counting upwards

Copy:
https://docs.google.com/document/d/1-QU-Yv17WjAa788tNFmAxWbTJT7NGY2snY5qPSEGlWk/edit

Design:
https://www.figma.com/file/XtEAabujYbKaP5mLnCtvVS/YouTube-User-Control-Report-Landing-Page?node-id=0%3A1

Image

@stevedya
Copy link
Collaborator

stevedya commented Sep 2, 2022

This is now ready for review here: #9298

@cdanfon
Copy link
Author

cdanfon commented Sep 6, 2022

Hey @siimonevans a few amends to this ticket on the work that @stevedya has done.

Mainly around view on figma file vs. staging site for desktop, mobile & tablet.

I've added a few screenshots comparing:

Desktop

Figma design:

Image

Staging site:

Image

Main difference on the above is the size of the cards, they seems to be taller on the staging site.

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

Tablet

Figma design:

Image

Staging site:

Image

Main difference on the above is the size of the cards and white space padding

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

Phone

Figma design:

Image

Staging site:

Image

Main difference on the above is the size of the cards and white space padding

@siimonevans
Copy link
Collaborator

PR open here.

tbrlpld added a commit that referenced this issue Sep 9, 2022
Youtube Regrets 2022 - Address stat font size/spacing #9261
@cdanfon cdanfon closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants