Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating a generic listing page and blog listing specific page #3427

Merged
merged 22 commits into from
Jul 29, 2019

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Jul 16, 2019

Closes #3370
Related PRs/issues #3371

This does not do any fancy "load initial subset, JS-enabled MORE button to load more results", given that the first use of this model is for blog posts, of which we only have a handful.

#3443 has been filed for the JS functionality.

Test

https://foundation-mofostaging-pr-3427.herokuapp.com/en/blog/

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3427 July 16, 2019 23:18 Inactive
@Pomax Pomax changed the title [WIP] generating a generic listing page and blog listing specific page Generating a generic listing page and blog listing specific page Jul 22, 2019
@Pomax Pomax marked this pull request as ready for review July 22, 2019 23:30
@Pomax Pomax requested a review from mmmavis July 22, 2019 23:31
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3427 July 22, 2019 23:39 Inactive
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3427 July 23, 2019 00:50 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3427 July 23, 2019 00:52 Inactive
@patjouk patjouk requested a deployment to foundation-mofostaging-pr-3427 July 23, 2019 15:42 Abandoned
@Pomax Pomax requested a deployment to foundation-mofostaging-pr-3427 July 23, 2019 15:43 Abandoned
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3427 July 23, 2019 15:43 Inactive
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3427 July 23, 2019 16:44 Inactive
@Pomax Pomax requested review from kristinashu and alanmoo July 23, 2019 16:56
@Pomax
Copy link
Contributor Author

Pomax commented Jul 23, 2019

@kristinashu this should be ready for design review

Copy link
Contributor

@alanmoo alanmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can tell you just by looking that the margins in the top section are wonky, you probably need a few .my-# classes in there or something like that. @kristinashu What's the best way to iron this out?

@kristinashu
Copy link

Thanks Pomax! A few questions and thoughts:

Tags

For the /blog page, can we show the first tag listed in the posts promote tab for each post?

Comp:
image

Filter view

Have you added the filter by tag view yet? I added the tag 'test' to one of the post then tried the url https://foundation-mofostaging-pr-3427.herokuapp.com/en/blog-list/?tag=[test] but it didn't change anything.

Comp:
image

Spacing

Just a bit of finessing is needed for the gaps. I'm reluctant to give exact px spacing but here is a comp with some guidelines. I know this will very slightly because of the preexisting spacing associated with the text so just use this comp as a guideline. Note, we stick to multiples of 8px.

image

@mmmavis
Copy link
Collaborator

mmmavis commented Jul 23, 2019

(Let me know if I should review this sooner. I usually wait for PR to pass design review first.)

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3427 July 23, 2019 23:41 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3427 July 25, 2019 15:46 Inactive
@Pomax
Copy link
Contributor Author

Pomax commented Jul 25, 2019

@kristinashu fixed the line widths, it should now be 8 at medium and above, and 12 at smaller than that.

@Pomax
Copy link
Contributor Author

Pomax commented Jul 25, 2019

The grey bar looks like the minisite nav without any content (because there is none) so I'll see if I can remove that nav from this template entirely.

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3427 July 25, 2019 15:59 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3427 July 25, 2019 15:59 Inactive
@Pomax
Copy link
Contributor Author

Pomax commented Jul 25, 2019

it was - removed the minisite-specific bits because this is not a minisite and what were they doing in the template in the first place here =P

Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t!

@Pomax
Copy link
Contributor Author

Pomax commented Jul 25, 2019

@kristinashu @mmmavis the Percy failure looks like a genuine concern: the "participation guidelines" gets spread out over two columns...

@kristinashu
Copy link

Why is this PR changing the footer?

@Pomax
Copy link
Contributor Author

Pomax commented Jul 25, 2019

Your guess is as good as mine: it's only showing changes in the footer for two (out of eleven?) pages, both entirely unrelated to this, and if I check those pages on the review app things look perfectly fine, so.... it could just be Percy being wrong? =/

@kristinashu
Copy link

Hmm weird, should we push to staging and then check those pages there?

@Pomax
Copy link
Contributor Author

Pomax commented Jul 25, 2019

That feels reasonable, although @mmmavis and @alanmoo will still need to R+ before we land.

Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  • In order for a page to show up on an index page, that page has to be child of the index page. This means child page urls will become /index-page/child-page. Will we running into issues with URL if we are planning to create index page of existing pages on production (e.g., their URL will change and we'll have to deal with redirects???)?
  • Will there be cases where we want a page to belong to more than one index page?

@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-3427 July 26, 2019 20:42 Inactive
@alanmoo
Copy link
Contributor

alanmoo commented Jul 26, 2019

Two questions:

* In order for a page to show up on an index page, that page has to be child of the index page. This means child page urls will become `/index-page/child-page`. Will we running into issues with URL if we are planning to create index page of existing pages on production (e.g., their URL will change and we'll have to deal with redirects???)?

We shouldn't; We've had mini-site namespace pages in place for a while, so this will be replacing some of those, making previously dead URLs into real ones.

* Will there be cases where we want a page to belong to more than one index page?

I think that's beyond the scope of intent for this page.

Copy link
Contributor

@alanmoo alanmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks way better and feels like the right approach. One tiny comment from me and another from Mavis, and I think we're all set.

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3427 July 29, 2019 16:12 Inactive
Copy link
Contributor

@alanmoo alanmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Pomax Pomax merged commit 64f78ca into master Jul 29, 2019
@Pomax Pomax deleted the blog-index branch February 6, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/blog page
5 participants