Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page for /blog?tag=[name] #3371

Closed
kristinashu opened this issue Jul 5, 2019 · 3 comments · Fixed by #3464
Closed

Page for /blog?tag=[name] #3371

kristinashu opened this issue Jul 5, 2019 · 3 comments · Fixed by #3464
Assignees
Labels
Milestone

Comments

@kristinashu
Copy link

kristinashu commented Jul 5, 2019

Blocked by related implementation ticket for /blog page #3370

Related design ticket #3165
Related blog epic ticket #2797

  • styles should follow the /blog page
  • should show the number of results and the selected tag (should match the same style as on pulse)
  • clicking clear filter tag should show users /blog

Comp

https://redpen.io/ztf6d6d69bc4aa274f

cc @alanmoo

This was referenced Jul 5, 2019
@alanmoo
Copy link
Contributor

alanmoo commented Jul 8, 2019

This will likely be a part of the same template as the main blog page, as some extra functionality supported by query parameters or something like that.

@Pomax
Copy link
Contributor

Pomax commented Aug 8, 2019

Given that results will be paginated, how do we want to indicate this? E.g. "Showing 12 of 50 results found", and updating that value as the user clicks "load more results"?

@Pomax
Copy link
Contributor

Pomax commented Aug 8, 2019

Also, given that the tag filtering is now a properly different URL, clear filters is probably either no longer necessary, or needs a design tweak. The base page is still /en/blog but the filtered pages now (necessarily) live on /en/blog/tags/(tags), so "clearing" is actually a navigation to /en/blog

@gideonthomas gideonthomas modified the milestones: Aug 5, Aug 19 Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants