Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PRO and all P-peptides #38

Merged
merged 6 commits into from
Feb 16, 2024
Merged

fix PRO and all P-peptides #38

merged 6 commits into from
Feb 16, 2024

Conversation

keitaroyam
Copy link
Contributor

@keitaroyam keitaroyam commented Dec 2, 2023

In #32 there was a mistake in PRO where N was considered sp2. This was fixed in Acedrg 279.

Edit: finally, all P-peptides have been updated

037 0IZ 04U 0Y8 05N 0LF 12Y 12L 12X 3PX 3V8 3WX 3V5 45W 4E5 4FB 45F 4E7 6Z4 7H5 7E5 8FB 8VE 8WQ 8VN ABX BG5 BG3 BG4 DPR DOQ E0Y FP9 G8X HYP H5M HY3 HZP JKH KAI MP8 OIC PH6 PDF PRJ PXU PRO Q42 RT0 SSC TG2 TJ5 TPJ UY7 UYA VUV VUY VV1 VH0 VUS VV4 XPR X7O XBG XFG YPR ZYJ ZYK

keitaroyam added a commit to keitaroyam/servalcat that referenced this pull request Dec 5, 2023
N-terminal Pro lead to geometry target of NaN, because of MonomerLibrary/monomers#38
@GaribMurshudov
Copy link
Contributor

did you also replace the link?

@keitaroyam
Copy link
Contributor Author

keitaroyam commented Dec 6, 2023

PRO has been updated again (Acedrg version number has not changed). Now N is protonated and DEL-HNP has also been updated.

TODO: check other P-peptides to see if H2 is not used. Perhaps all P-peptides should also be updated.

did you also replace the link?

Did not update the link using Acedrg. Just added H2 deletion to DEL-HNP.

@GaribMurshudov
Copy link
Contributor

New energy type for N should be N30, i.e. sp2 N with three bonds, none of them H

@keitaroyam
Copy link
Contributor Author

keitaroyam commented Dec 6, 2023

Shouldn't it be NR5? Acedrg 279 has actually put NR5 with:

LINK: RES-NAME-1 ALA ATOM-NAME-1 C RES-NAME-2 PRO ATOM-NAME-2  N DELETE ATOM OXT 1 CHANGE CHARGE 2 N 0

@GaribMurshudov
Copy link
Contributor

GaribMurshudov commented Dec 6, 2023

NR5 is reserved for N on five membered aromatic rings with no H. It should be able to become an acceptor. N30 is neither acceptor nor donor.
And: I would like these to be dealt automatically within aceDRG

keitaroyam added a commit to project-gemmi/gemmi that referenced this pull request Dec 11, 2023
Chiral volume may become NaN in come cases. An example is the current PRO's chir_2, which will be fixed by MonomerLibrary/monomers#38
@GaribMurshudov
Copy link
Contributor

What are the remaining problems related to this branch. I would like to fix it with the help of @flong-mrc

@keitaroyam
Copy link
Contributor Author

Now Pro has two hydrogen (H and H2; H2 is an extra hydrogen nonexistent in the CCD) bonded to N, so all P-peptide monomers should be updated accordingly. Then it's better to use H/H2 names consistently (otherwise we need an alias).

The current Acedrg (279), however, adds an extra H3 to YPR, while in the CCD H2 is bonded to N (and there is no "H" in the monomer). Fei mentioned he would fix Acedrg to use "H" as an extra hydrogen in this case.

Also, the aforementioned NR5/N30 problem should be fixed (we can do it manually, but it's better to fix Acedrg).

@GaribMurshudov
Copy link
Contributor

Thank you. it is clear now. I will talk to @flong-mrc tomorrow

@keitaroyam keitaroyam changed the title fix PRO using Acedrg 279 fix PRO and all P-peptides Jan 17, 2024
@keitaroyam
Copy link
Contributor Author

keitaroyam commented Jan 17, 2024

All PRO-like peptides have been updated to have two hydrogen atoms using (pre-release) Acedrg 281. DEL-HNP was also fixed, now the type of N is NH0.

Please test!

@keitaroyam
Copy link
Contributor Author

12L has been updated, which was missed due to an Acedrg installation issue.

I was worried about the sigma values of omega, but a quick analysis of high res (1.5 A or better) PDB models told 5 degrees are reasonable for PTRANS/PCIS links, while Acedrg now gives 20 degrees.

I think this branch can be merged.

@GaribMurshudov
Copy link
Contributor

Is not omega sp2-sp2 torsion angle? I thought acedrg sigma for these cases is 5.

Copy link
Contributor

@GaribMurshudov GaribMurshudov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this quickly. It looks fine to me.

@keitaroyam
Copy link
Contributor Author

Is not omega sp2-sp2 torsion angle? I thought acedrg sigma for these cases is 5.

This is about P-peptides. In my understanding Acedrg has changed to give large sigmas for large substituents.

@GaribMurshudov
Copy link
Contributor

Is not omega a part of links? Within sungle peptides we will have sp2-sp3 links. I may be missing something

@keitaroyam
Copy link
Contributor Author

Yes it's part of links. All omegas (for peptides, P-peptides, and M-peptides) have sigma value of 5 degrees. I meant this seems ok as it is.

And with

LINK: RES-NAME-1 ALA ATOM-NAME-1 C RES-NAME-2 PRO ATOM-NAME-2 N DELETE ATOM OXT 1

Acedrg 284 gives

ALA-PRO sp2_sp2_1 1 CA 1 C 2 N 2 CA 180.000 20 2
ALA-PRO sp2_sp3_1 1 C 2 N 2 CD 2 CG 180.000 10.0 6

@GaribMurshudov
Copy link
Contributor

It needs to change. @flong-mrc could you please have a look this? We will change these when we have proper torsion angle statistics.

@flong-mrc
Copy link

flong-mrc commented Feb 15, 2024 via email

@GaribMurshudov
Copy link
Contributor

I think for now we should have:
sp2-sp2 sigma 5
sp3-sp3 sigma 10
sp2-sp3 sigma 20 (we could make it five also, since period is 6 then 20 means that it can go from one minimum to another easily, distance between minimum of the energy and maximum will be 30 degrees)
Obviously we should have better statistics for these things

@flong-mrc
Copy link

flong-mrc commented Feb 15, 2024 via email

@keitaroyam
Copy link
Contributor Author

Thank you Fei, it now gave "right" sigma values.

@keitaroyam keitaroyam merged commit 828e23c into master Feb 16, 2024
1 check passed
@keitaroyam keitaroyam deleted the fix-pro branch February 16, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants