Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Introduce ImplicitBPRWrapper model #232

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chezou
Copy link
Contributor

@chezou chezou commented Dec 11, 2024

Description

Address #132

As a first step, don't support features at this moment since it requires to additional design for CPU implementation because CPU BPR class is fully Cythonized.

While I tried to keep deterministic for unit tests, BPR updates random states every fit, so I gave up some tests. Some tests may flakey.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (5f3211d).
Report is 86 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #232     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        60     +15     
  Lines         2242      3970   +1728     
===========================================
+ Hits          2242      3970   +1728     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chezou chezou force-pushed the feature/bpr branch 5 times, most recently from 1fa6a73 to 2f096b6 Compare December 12, 2024 00:51
@chezou chezou changed the title Introduce ImplicitBPRWrapper model [Experimental] Introduce ImplicitBPRWrapper model Dec 12, 2024
@chezou chezou marked this pull request as ready for review December 12, 2024 01:15
pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants