Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec(ActivityPub): メンションされていない場合は個別ユーザーのinboxに届いた限定公開のPostは通知を作成しないように #365

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

u1-liquid
Copy link
Member

What

Fedibirdのサークルは相互フォロー限定公開みたいな意味合いなので別にメンションではないらしい

Why

メンションされていないのに通知が作成されてしまい困惑することがあるらしいので

Additional info (optional)

related: #361

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
5.5% Duplication on New Code

See analysis details on SonarCloud

@u1-liquid u1-liquid merged commit 6fa77ef into MisskeyIO:io Jan 16, 2024
16 checks passed
@u1-liquid u1-liquid deleted the sp-no-noti-per-user-inbox branch January 16, 2024 12:50
u1-liquid pushed a commit that referenced this pull request Jan 22, 2024
…sskey-dev#13044)

`/users/:user`, `/@:user`, `/notes/:note` return different responses
depending on the request's `Accept:` header. If we don't consistently
return a `Vary: Accept` header, browsers and caching proxies will get
confused, and return AP representations when HTML was requested, or
vice versa.

Co-authored-by: dakkar <[email protected]>
Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants