Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec(ActivityPub): 個別ユーザーのinboxに届いた限定公開のPostはそのユーザーに閲覧権限があると見なす #361

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

u1-liquid
Copy link
Member

What

Fedibirdのサークル、Hubzillaの限定公開タイプのPostの場合、
公開範囲specifiedのアクティビティがそれぞれのユーザーの個別inboxに届く仕様になっているため、
個別のinboxに届いたPostをそのユーザーが見れない場合はvisibleUserIdsを更新し、タイムラインや通知などの処理を行う

Why

resolves #354

Additional info (optional)

https://misskey.io/notes/9odvrk1kagpl003v

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

riku6460
riku6460 previously approved these changes Jan 15, 2024
Copy link

sonarqubecloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@u1-liquid u1-liquid requested a review from riku6460 January 15, 2024 22:34
@u1-liquid u1-liquid merged commit 83bf53c into MisskeyIO:io Jan 15, 2024
16 checks passed
@u1-liquid u1-liquid deleted the ap-per-user-inbox branch January 15, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

個別ユーザーのinboxに届いたノートなどはそのユーザーが見れるものとする
2 participants