A lot of modifications #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when deprecating iteration interface, `isapprox` cannot be applied onto `EquationOfState`s
this cannot fix #31, an iteration interface still need to be defined. And once it is defined, the error emerges.
should be replaced in linear fitting
Add unit support
for unit "angstrom"
Refactor module `NonlinearFitting` using traits
or else it fails on CIs
in src/Find.jl
to let `median` works
in favor of function chaining operator `|>`. See https://painterqubits.github.io/Unitful.jl/latest/conversion/
Unitful.jl has merged my PR PainterQubits/Unitful.jl#271
to use Unitful.jl `master` branch
Restyle A lot of modifications
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
===========================================
- Coverage 49.5% 33.65% -15.85%
===========================================
Files 7 7
Lines 202 205 +3
===========================================
- Hits 100 69 -31
- Misses 102 136 +34
Continue to review full report at Codecov.
|
`eltype(eos)` is `Any`, which results in the `promote_type` returns an `Any`.
which was deprecated before.
with `Unitful`
Deprecate the multiple-type-parameter EOS
singularitti
added a commit
to MineralsCloud/Express.jl
that referenced
this pull request
Oct 10, 2019
after EquationsOfState.jl has closed PR MineralsCloud/EquationsOfState.jl#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including PR:
NonlinearFittingusing traits #34findvolumefor EOS with units #35findvolumewhen it comes to EOS with units #36and other changes