Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let EquationOfStates not be iterable #31

Closed
singularitti opened this issue Sep 27, 2019 · 0 comments
Closed

Let EquationOfStates not be iterable #31

singularitti opened this issue Sep 27, 2019 · 0 comments
Labels
deprecation

Comments

@singularitti
Copy link
Member

singularitti commented Sep 27, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
In #24, I made EquationOfStates iterable. But now I do not think it is necessary. Because it makes it harder to write

g = apply(PressureForm(), trial_eos)
f(x) = @. ustrip(u"kbar", g(x) * u"Ry/a0_au^3")
map(f, volumes)

into a one-liner. Because the fusion operator will operate on EquationOfStates, too, since it is an iterable.

Describe the solution you'd like
Deprecate the iterable interface introduced in commit "ffba5bf58e1ac8c58176ea92a4f0fff2064aa4c0".
@singularitti singularitti mentioned this issue Sep 27, 2019
Merged
singularitti added a commit that referenced this issue Sep 27, 2019
@singularitti
Deprecate length for EquationOfState
921e68f 
this cannot fix #31, an iteration interface
still need to be defined. And once it is defined,
the error emerges.
singularitti added a commit that referenced this issue Sep 27, 2019
@singularitti
Merge pull request #32 from MineralsCloud/feature/iterable
86eb3af 
Solve issue #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@singularitti