Solve issues mentioned in #23 and #24 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method I want is like `Murnaghan(v0, b0, bp0) = Murnaghan(v0, b0, bp0, 0)`, not what `Parameters.@with_kw` provides.
Use `IterTools.fieldvalues`
and `fieldvalues`
Deprecate one method of `lsqfit`
instead of `convert(Vector{T}, *)`
Because `EquationOfState`s are iterable now.
singularitti
changed the title
This was referenced Sep 25, 2019
Merged
|
Please be aware of this change. @searchengineorientprogramming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve issues mentioned in #23 and #24:
EquationOfStateas a subtype ofFieldVector, and thus remove StaticArrays.jl from dependenciesEquationOfStateas keyword structs (provided by Parameters.jl). I only neede0 = 0in the EOSs, which is the last parameter. So a simple outer constructor would solve this problem. Parameters.jl, instead, does not provide features fit my needs.EquationOfStateiterable by implementing iteration interface. And implementisapproxfor it. Thoughisapproxis originally forAbstractArrays, it is helpful so that I do not need to change my tests, which uses a lot ofisapprox.