Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate EquationOfState as a subtype of FieldVector #23

Closed
singularitti opened this issue Sep 24, 2019 · 1 comment
Closed

Deprecate EquationOfState as a subtype of FieldVector #23

singularitti opened this issue Sep 24, 2019 · 1 comment
Labels
deprecation
Milestone
v2.0.0

Comments

@singularitti
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently every EquationOfState{T,N} <: FieldVector{N,T}. But I am considering not to implement EquationOfStates by vectors.

Describe the solution you'd like
Deprecate the subtype of FieldVector and fix every related field.
@singularitti singularitti modified the milestones: 2.0.0, v2.0.0 Sep 24, 2019
@singularitti singularitti mentioned this issue Sep 25, 2019
Closed
@singularitti singularitti changed the title Deprecate EquationOfState as a FieldVector Deprecate EquationOfState as a subtype of FieldVector Sep 25, 2019
This was referenced Sep 25, 2019
Merged
Closed
singularitti added a commit that referenced this issue Sep 25, 2019
@singularitti
Merge pull request #25 from MineralsCloud/feature/vector
524e3d7 
Solve issues mentioned in #23 and #24
@singularitti
Copy link
Member Author

Solved by #25.

singularitti pushed a commit that referenced this issue Sep 25, 2019
docs: Update docs in docs/src/Collections.md
3ff3c04 
Add formula to `PoirierTarantola3rd`
# Explain why this change is being made
# |<----   Try To Limit Each Line to a Maximum Of 72 Characters   ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: Github issue #23

# --- COMMIT END ---
# Type can be
#    feat     (new feature)
#    fix      (bug fix)
#    refactor (refactoring production code)
#    style    (formatting, missing semi colons, etc; no code change)
#    docs     (changes to documentation)
#    test     (adding or refactoring tests; no production code change)
#    chore    (updating grunt tasks etc; no production code change)
# --------------------
# Remember to
#    Capitalize the subject line
#    Use the imperative mood in the subject line
#    Do not end the subject line with a period
#    Separate subject from body with a blank line
#    Use the body to explain what and why vs. how
#    Can use multiple lines with "-" for bullet points in body
# --------------------
# For more information about this template, check out
# https://gist.github.com/adeekshith/cd4c95a064977cdc6c50
singularitti pushed a commit that referenced this issue Sep 25, 2019
Add docs for eos fomulation
1fc9a4b 
# Explain why this change is being made
# |<----   Try To Limit Each Line to a Maximum Of 72 Characters   ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: Github issue #23

# --- COMMIT END ---
# Type can be
#    feat     (new feature)
#    fix      (bug fix)
#    refactor (refactoring production code)
#    style    (formatting, missing semi colons, etc; no code change)
#    docs     (changes to documentation)
#    test     (adding or refactoring tests; no production code change)
#    chore    (updating grunt tasks etc; no production code change)
# --------------------
# Remember to
#    Capitalize the subject line
#    Use the imperative mood in the subject line
#    Do not end the subject line with a period
#    Separate subject from body with a blank line
#    Use the body to explain what and why vs. how
#    Can use multiple lines with "-" for bullet points in body
# --------------------
# For more information about this template, check out
# https://gist.github.com/adeekshith/cd4c95a064977cdc6c50
singularitti pushed a commit that referenced this issue Sep 25, 2019
Add md docs for eos fomulations
e313ec9 
# Explain why this change is being made
# |<----   Try To Limit Each Line to a Maximum Of 72 Characters   ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: Github issue #23

# --- COMMIT END ---
# Type can be
#    feat     (new feature)
#    fix      (bug fix)
#    refactor (refactoring production code)
#    style    (formatting, missing semi colons, etc; no code change)
#    docs     (changes to documentation)
#    test     (adding or refactoring tests; no production code change)
#    chore    (updating grunt tasks etc; no production code change)
# --------------------
# Remember to
#    Capitalize the subject line
#    Use the imperative mood in the subject line
#    Do not end the subject line with a period
#    Separate subject from body with a blank line
#    Use the body to explain what and why vs. how
#    Can use multiple lines with "-" for bullet points in body
# --------------------
# For more information about this template, check out
# https://gist.github.com/adeekshith/cd4c95a064977cdc6c50
searchengineorientprogramming added a commit to searchengineorientprogramming/EquationsOfState.jl that referenced this issue Dec 6, 2019
@searchengineorientprogramming
update change
9b8c820 
# Explain why this change is being made
# |<----   Try To Limit Each Line to a Maximum Of 72 Characters   ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: Github issue MineralsCloud#23

# --- COMMIT END ---
# Type can be
#    feat     (new feature)
#    fix      (bug fix)
#    refactor (refactoring production code)
#    style    (formatting, missing semi colons, etc; no code change)
#    docs     (changes to documentation)
#    test     (adding or refactoring tests; no production code change)
#    chore    (updating grunt tasks etc; no production code change)
# --------------------
# Remember to
#    Capitalize the subject line
#    Use the imperative mood in the subject line
#    Do not end the subject line with a period
#    Separate subject from body with a blank line
#    Use the body to explain what and why vs. how
#    Can use multiple lines with "-" for bullet points in body
# --------------------
# For more information about this template, check out
# https://gist.github.com/adeekshith/cd4c95a064977cdc6c50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@singularitti