Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FindVolume module to Find #29

Closed
singularitti opened this issue Sep 25, 2019 · 1 comment
Closed

Rename FindVolume module to Find #29

singularitti opened this issue Sep 25, 2019 · 1 comment

Comments

@singularitti
Copy link
Member

Is your feature request related to a problem? Please describe.
FindVolume corresponds to find_volume in snake case. But to be consistent with Julia's internal findnext, findfirst, findlast, etc., I use findvolume, which also conflicts with Roots.find_zero in the same file. To avoid inconsistency in my own naming convention, I decide to keep findvolume as the function's name and rename FindVolume module to Find.
singularitti added a commit that referenced this issue Sep 25, 2019
@singularitti
Rename FindVolume module to Find #29
0b99d3f
@singularitti singularitti mentioned this issue Sep 25, 2019
Merged
@singularitti
Copy link
Member Author

Please be aware of this change. @searchengineorientprogramming

singularitti added a commit that referenced this issue Sep 25, 2019
@singularitti
Merge pull request #30 from MineralsCloud/feature/rename
e58654a 
Solve issues #28 and #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@singularitti