Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EquationOfStateForm to EquationForm #28

Closed
singularitti opened this issue Sep 25, 2019 · 1 comment
Closed

Rename EquationOfStateForm to EquationForm #28

singularitti opened this issue Sep 25, 2019 · 1 comment

Comments

@singularitti
Copy link
Member

Is your feature request related to a problem? Please describe.
The most important abstract type EquationOfStateForm sounds misleading: the form of an equation of state. In fact, an equation of state composes of 2 parts:

  1. the relation: energy-/pressure-/bulkmodulus-volume relation; and
  2. the material: i.e., the 2-5 parameters of the EquationOfState.

Describe the solution you'd like
Rename it to EquationForm, it is more concise and does not reflect the over general meaning stated above.
singularitti added a commit that referenced this issue Sep 25, 2019
@singularitti
docs: Rename EquationOfStateForm to EquationForm in docs/
7a06f80 
solve #28.
@singularitti
Copy link
Member Author

Please be aware of this change. @searchengineorientprogramming

@singularitti singularitti mentioned this issue Sep 25, 2019
Merged
singularitti added a commit that referenced this issue Sep 25, 2019
@singularitti
Merge pull request #30 from MineralsCloud/feature/rename
e58654a 
Solve issues #28 and #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@singularitti