Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LogDestination's Logger conformance log level filtering 🪵 #248

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Fix LogDestination's Logger conformance log level filtering 🪵 #248

merged 2 commits into from
Jan 5, 2022

Commits on Jan 5, 2022

  1. Fix LogDestinations Logger conformance log level filtering 🪵 

    When `Logger` conformance was added to `LogDestination`, we forgot to
filter logs according to the destination's `minLevel`, causing all logs
to be logged regardless of the level.

## Changes

- Add log level filtering to `LogDestination`'s `Logger` conformance,
as well as relevant UTs.

- Rename `Log.Level.isAbove(minLevel:)` helper to `meets(minLevel:)`.
    @p4checo
    p4checo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    39c0114 View commit details
    Browse the repository at this point in the history

  2. CR changes

    @p4checo
    p4checo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    b142c57 View commit details
    Browse the repository at this point in the history