Fix LogDestination's Logger conformance log level filtering 🪵
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `Logger` conformance was added to `LogDestination`, we forgot to filter logs according to the destination's `minLevel`, causing all logs to be logged regardless of the level. ## Changes - Add log level filtering to `LogDestination`'s `Logger` conformance, as well as relevant UTs. - Rename `Log.Level.isAbove(minLevel:)` helper to `meets(minLevel:)`.
p4checo
changed the title
LogDestinations Logger conformance log level filtering 🪵LogDestination's Logger conformance log level filtering 🪵
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 94.96% 94.97%
=======================================
Files 99 99
Lines 3280 3281 +1
=======================================
+ Hits 3115 3116 +1
Misses 165 165
Continue to review full report at Codecov.
|
aclima93
reviewed
Jan 5, 2022
aclima93
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
When
Loggerconformance was added toLogDestination, we forgot to filter logs according to the destination'sminLevel, causing all logs to be logged regardless of the level.Description
Add log level filtering to
LogDestination'sLoggerconformance, as well as relevant UTs.Rename
Log.Level.isAbove(minLevel:)helper tomeets(minLevel:).