Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-106: Fix using add_child on before() in test suites do not break the API #107

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

MikeSchulze
Copy link
Owner

  • adding custom nodes on the test suite before() was break the test case execution
    solved by adding a typeof check when iteration over the childs to only execute on test case

…he API

- adding custom nodes on the test suite `before()` was break the test case execution
  solved by adding a typeof check when iteration over the childs to only execute on test case
@MikeSchulze MikeSchulze self-assigned this Jul 4, 2021
@MikeSchulze MikeSchulze linked an issue Jul 4, 2021 that may be closed by this pull request
@MikeSchulze MikeSchulze added this to the v0.9.7-rc milestone Jul 4, 2021
@MikeSchulze MikeSchulze added bug Something isn't working critical A problem with a critical error must be fixed in the near future if possible labels Jul 4, 2021
@MikeSchulze MikeSchulze merged commit 019a7dc into master Jul 4, 2021
@MikeSchulze MikeSchulze deleted the GD-106 branch July 4, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical A problem with a critical error must be fixed in the near future if possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-106: add_child() on TestSuite#before() breaks the API
1 participant