Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-106: add_child() on TestSuite#before() breaks the API #106

Closed
MikeSchulze opened this issue Jul 4, 2021 · 0 comments · Fixed by #107
Closed

GD-106: add_child() on TestSuite#before() breaks the API #106

MikeSchulze opened this issue Jul 4, 2021 · 0 comments · Fixed by #107
Assignees
@MikeSchulze
Labels
bug Something isn't working critical A problem with a critical error must be fixed in the near future if possible
Milestone
v0.9.7-rc

Comments

@MikeSchulze
Copy link
Owner

The used Godot version:
Godot 3.x

OS including version:
All

Describe the bug
When adding a custom child node on before() in a test suite stops on Run Debug with an error

Invalid call. Nonexistent function 'get_name' in base 'Nil'.

Steps to Reproduce

extends GdUnitTestSuite

func before():
        # this line let the suite fail on 'Run Debug'
	add_child(auto_free(Node.new()))

func test_case1():
	assert_str("test_case1").is_equal("test_case1")

func test_case2():
	assert_str("test_case2").is_equal("test_case2")
@MikeSchulze MikeSchulze added the bug Something isn't working label Jul 4, 2021
@MikeSchulze MikeSchulze self-assigned this Jul 4, 2021
@MikeSchulze MikeSchulze added the critical A problem with a critical error must be fixed in the near future if possible label Jul 4, 2021
@MikeSchulze MikeSchulze added this to the v0.9.7-rc milestone Jul 4, 2021
@MikeSchulze MikeSchulze changed the title add_child() on TestSuite#before() breaks the API GD-106: add_child() on TestSuite#before() breaks the API Jul 4, 2021
@MikeSchulze MikeSchulze linked a pull request Jul 4, 2021 that will close this issue
GD-106: Fix using add_child on before() in test suites do not break the API #107
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
bug Something isn't working critical A problem with a critical error must be fixed in the near future if possible
Projects
None yet
Milestone
v0.9.7-rc
Development

Successfully merging a pull request may close this issue.

GD-106: Fix using add_child on before() in test suites do not break the API MikeSchulze/gdUnit3
1 participant
@MikeSchulze