Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #674 cant move / edit mp3 #695

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Bugfix #674 cant move / edit mp3 #695

merged 2 commits into from
Jan 8, 2020

Conversation

ctietze
Copy link
Contributor

@ctietze ctietze commented Jan 3, 2020

No description provided.

@ctietze
Bugfix moving files w/ whitespaces #674
35e36eb 
- Use php build-in rename function instead of system call
- Only rename file iff
  - the target folder exists
  - source and target are different
  - source and target contains the $Audio_Folders_Path

Minor changes
- introduce a String and Files helper class
- fixed playerTest and playListTest to work with current version
@ctietze
Fix edit track information #674
ed3c031 
- Quote filename to handle files and folders /w whitespaces
- Change the way of adding mid3v2 cli options for artist, song, album and composer according to
https://mutagen.readthedocs.io/en/latest/man/mid3v2.html
@MiczFlor
Copy link
Owner

MiczFlor commented Jan 4, 2020

Hi @ctietze
do you have this running locally? I haven't tested it yet, won't have time until next week. But would like to know if this is the latest state of the art code from you?

@ctietze ctietze changed the title Bugfix/674 cant move mp3 Bugfix #674 cant move / edit mp3 Jan 4, 2020
@ctietze
Copy link
Contributor Author

ctietze commented Jan 4, 2020 •
edited
Loading

Hi @MiczFlor ,
yes I checked the issue #674 reported by @Reddi82 exists. I wrote two tests and tested it locally.
State of the art is a hard word related to the code base. Just from the objective view, no criticism. It is rather the boy scout rule. Leave your code better than you found it... ;)
BR Clemens

@MiczFlor MiczFlor merged commit 139e1a9 into MiczFlor:develop Jan 8, 2020
@MiczFlor
Copy link
Owner

MiczFlor commented Jan 8, 2020

Hi @ctietze
with "latest state of the art" I meant: your latest version as commits. Not the coding :) As you see, in Phoniebox, rule number one is: there are no rules :)

@ctietze
Copy link
Contributor Author

ctietze commented Jan 8, 2020

🤣 ok. Yes it was the last commit

@s-martin s-martin mentioned this pull request Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctietze @MiczFlor