Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change MP3-Details (Title, Artist, ...) via Web-interface #674

Closed
Reddi82 opened this issue Dec 21, 2019 · 4 comments
Closed

Can't change MP3-Details (Title, Artist, ...) via Web-interface #674

Reddi82 opened this issue Dec 21, 2019 · 4 comments

Comments

@Reddi82
Copy link

Reddi82 commented Dec 21, 2019

I think the problem are some blanks in my file- and folder-names. Here is my solution:

In file "RPi-Jukebox-RFID/htdocs/trackEdit.php" change following lines:

Actual 178: $exec = "mv ".$post['folder']."/".$post['filename']." ".$Audio_Folders_Path."/".$_POST['folderNew']."/";
New 178: $exec = 'mv "'.$post['folder'].'/'.$post['filename'].'" "'.$Audio_Folders_Path.'/'.$_POST['folderNew'].'/"';

Actual 202: $exec = 'mid3v2 --artist "'.replaceUmlaute($post['trackArtist']).'" '.$post['folder'].'/'.$post['filename'];
New 202: $exec = 'mid3v2 --artist="'.replaceUmlaute($post['trackArtist']).'" "'.$post['folder'].'/'.$post['filename'].'"';

Actual 207: $exec = "mid3v2 --song '".replaceUmlaute($post['trackTitle'])."' ".$post['folder']."/".$post['filename'];
New 207: $exec = 'mid3v2 --song="'.replaceUmlaute($post['trackTitle']).'" "'.$post['folder'].'/'.$post['filename'].'"';

Actual 212: $exec = "mid3v2 --album '".replaceUmlaute($post['trackAlbum'])."' ".$post['folder']."/".$post['filename'];
New 212: $exec = 'mid3v2 --album="'.replaceUmlaute($post['trackAlbum']).'" "'.$post['folder'].'/'.$post['filename'].'"';

Actual 219: $exec = "mid3v2 --TCOM '".replaceUmlaute($post['trackComposer'])."' ".$post['folder']."/".$post['filename'];
New 219: $exec = 'mid3v2 --TCOM="'.replaceUmlaute($post['trackComposer']).'" "'.$post['folder'].'/'.$post['filename'].'"';

Actual 244: $exec = "mid3v2 -l ".$post['folder']."/".$post['filename'];
New 244: $exec = 'mid3v2 -l "'.$post['folder'].'/'.$post['filename'].'"';

Because I can't move any files from folder to folder, I found this solution (with actual/old Line the path will doubled (path from line 172+375 and 173+375: /home/pi/RPi-Jukebox-RFID/shared/audiofolders/home/pi/RPi-Jukebox-RFID/shared/audiofolders/.../Xy.mp3):

Actual 375: print " <option value='".$keyfolder."'";
New 375: print " <option value='".$audiofolder."'"; //$keyfolder

@ctietze
Copy link
Contributor

ctietze commented Dec 23, 2019

Hi @Reddi82,
I can confirm your issues... I wonder if mid3v2 changed its API. I will try to provide a PR with the bugfixes.
BR Clemens

MiczFlor added a commit that referenced this issue Jan 8, 2020
@s-martin
Copy link
Collaborator

s-martin commented Mar 7, 2020

Did #695 fix this? So this issue could be closed.

@shoex
Copy link

shoex commented Mar 14, 2020

Did #695 fix this? So this issue could be closed.

For me it doesnt work. Tried today with an fresh install.

@s-martin
Copy link
Collaborator

s-martin commented May 5, 2023

Closing this now. Feel free to reopen, if the problem persists.

@s-martin s-martin closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants