Review of remove dynamic params

.gitignore

@@ -23,6 +23,8 @@ Source/Classes/vsteam.classes.ps1
 /dist
 test-results.xml
 coverage.xml
+.editorconfig
+.vscode/settings.json
 .DS_Store
 ._.DS_Store
 **/.DS_Store

.vscode/settings.json

@@ -49,18 +49,9 @@
       "vssgp",
       "vssps"
    ],
-   "workbench.colorCustomizations": {
-      "activityBar.background": "#007699",
-      "activityBar.foreground": "#e7e7e7",
-      "activityBar.inactiveForeground": "#e7e7e799",
-      "activityBarBadge.background": "#ff80e2",
-      "activityBarBadge.foreground": "#15202b",
-      "titleBar.activeBackground": "#004f66",
-      "titleBar.inactiveBackground": "#004f6699",
-      "titleBar.activeForeground": "#e7e7e7",
-      "titleBar.inactiveForeground": "#e7e7e799",
-      "statusBar.background": "#004f66",
-      "statusBarItem.hoverBackground": "#007699",
-      "statusBar.foreground": "#e7e7e7"
-   }
+   "terminal.integrated.commandsToSkipShell": [
+      "PowerShell.RunSelection",
+      "workbench.action.files.save",
+      "workbench.action.files.newUntitled"
+   ]
 }

Build-Module.ps1

@@ -86,7 +86,7 @@ Copy-Item -Path ./Source/VSTeam.psm1 -Destination "$output/VSTeam.psm1" -Force
 
 Write-Output 'Updating Functions To Export'
 $newValue = ((Get-ChildItem -Path "./Source/Public" -Filter '*.ps1').BaseName |
-      ForEach-Object -Process { Write-Output "'$_'" }) -join ','
+   ForEach-Object -Process { Write-Output "'$_'" }) -join ','
 
 (Get-Content "./Source/VSTeam.psd1") -Replace ("FunctionsToExport.+", "FunctionsToExport = ($newValue)") | Set-Content "$output/VSTeam.psd1"
 
@@ -107,7 +107,7 @@ if ($ipmo.IsPresent -or $runTests.IsPresent) {
 
 # run the unit tests with Pester
 if ($runTests.IsPresent) {
-   if ($null -eq $(Get-Module -Name Pester)) {
+   if ($null -eq $(Get-Module -ListAvailable Pester)) {
       Install-Module -Name Pester -Repository PSGallery -Force -Scope CurrentUser -AllowClobber -SkipPublisherCheck
    }
 
@@ -120,7 +120,7 @@ if ($runTests.IsPresent) {
    }
 
    if ($codeCoverage.IsPresent) {
-      $pesterArgs.CodeCoverage = "$outputDir\*.ps1"
+      $pesterArgs.CodeCoverage = "./Source/**/*.ps1"
       $pesterArgs.CodeCoverageOutputFile = "coverage.xml"
       $pesterArgs.CodeCoverageOutputFileFormat = 'JaCoCo'
    }

CHANGELOG.md

@@ -4,6 +4,15 @@
 
 _callAPI, _buildRequestURI and Invoke-VSTeamRequest now support UseProjectId switch if the Project ID is required for the API call.
 
+Addressed following issues:
+
+- Do not change the strict mode setting for the user's PowerShell session [#296](https://github.com/DarqueWarrior/vsteam/issues/296)
+- Consider reducing the scope of the default parameter "Project" from "*" to "*-VsTeam*" [#297](https://github.com/DarqueWarrior/vsteam/issues/297)
+
+Merged [Pull Request](https://github.com/DarqueWarrior/vsteam/pull/275) from [Jhoneill](https://github.com/jhoneill) which included the following:
+
+- Removing Dynamic parameters for completer and validator attributes.
+
 Merged [Pull Request](https://github.com/DarqueWarrior/vsteam/pull/283) from [Sebastian Schütze](https://github.com/SebastianSchuetze) which included the following:
 
 - Added Get-VSTeamBuildTimeline to get timeline of a build
@@ -898,4 +907,4 @@ Merged [Pull Request](https://github.com/DarqueWarrior/vsteam/pull/3) from [Andy
 
 ## 0.1.14
 
-Initial Open Source release
+Initial Open Source release

Source/Classes/BuildCompleter.ps1

@@ -0,0 +1,41 @@
+using namespace System.Collections
+using namespace System.Collections.Generic
+using namespace System.Management.Automation
+
+# This class defines an attribute that allows the user the tab complete
+# build numbers for function parameters. For this completer to work the
+# users must have already provided the ProjectName parameter for the
+# function or set a default project.
+class BuildCompleter : IArgumentCompleter {
+   [IEnumerable[CompletionResult]] CompleteArgument(
+      [string] $CommandName,
+      [string] $ParameterName,
+      [string] $WordToComplete,
+      [Language.CommandAst] $CommandAst,
+      [IDictionary] $FakeBoundParameters) {
+
+      $results = [List[CompletionResult]]::new()
+
+      # If the user has explictly added the -ProjectName parameter
+      # to the command use that instead of the default project.
+      $projectName = $FakeBoundParameters['ProjectName']
+
+      # Only use the default project if the ProjectName parameter was
+      # not used
+      if (-not $projectName) {
+         $projectName = _getDefaultProject
+      }
+
+      # If there is no projectName by this point just return a empty
+      # list.
+      if ($projectName) {
+         foreach ($b in (Get-VSTeamBuild -ProjectName $projectName)) {
+            if ($b.buildNumber -like "$WordToComplete*") {
+               $results.Add([CompletionResult]::new($b.buildNumber))
+            }
+         }
+      }
+
+      return $results
+   }
+}

Source/Classes/BuildDefinitionCompleter.ps1

@@ -0,0 +1,41 @@
+using namespace System.Collections
+using namespace System.Collections.Generic
+using namespace System.Management.Automation
+
+# This class defines an attribute that allows the user the tab complete
+# build definition names for function parameters. For this completer to
+# work the users must have already provided the ProjectName parameter for
+# the function or set a default project.
+class BuildDefinitionCompleter : IArgumentCompleter {
+   [IEnumerable[CompletionResult]] CompleteArgument(
+      [string] $CommandName,
+      [string] $ParameterName,
+      [string] $WordToComplete,
+      [Language.CommandAst] $CommandAst,
+      [IDictionary] $FakeBoundParameters) {
+
+      $results = [List[CompletionResult]]::new()
+
+      # If the user has explictly added the -ProjectName parameter
+      # to the command use that instead of the default project.
+      $projectName = $FakeBoundParameters['ProjectName']
+
+      # Only use the default project if the ProjectName parameter was
+      # not used
+      if (-not $projectName) {
+         $projectName = _getDefaultProject
+      }
+
+      # If there is no projectName by this point just return a empty
+      # list.
+      if ($projectName) {
+         foreach ($b in (Get-VSTeamBuildDefinition -ProjectName $projectName)) {
+            if ($b.name -like "*$WordToComplete*") {
+               $results.Add([CompletionResult]::new($b.name))
+            }
+         }
+      }
+
+      return $results
+   }
+}

Source/Classes/ProcessTemplateCompleter.ps1

@@ -0,0 +1,30 @@
+using namespace System.Collections
+using namespace System.Collections.Generic
+using namespace System.Management.Automation
+
+# This class defines an attribute that allows the user the tab complete
+# process templates for function parameters.
+class ProcessTemplateCompleter : IArgumentCompleter {
+   [IEnumerable[CompletionResult]] CompleteArgument(
+      [string] $CommandName,
+      [string] $ParameterName,
+      [string] $WordToComplete,
+      [Language.CommandAst] $CommandAst,
+      [IDictionary] $FakeBoundParameters) {
+
+      $results = [List[CompletionResult]]::new()
+
+      if (_hasProcessTemplateCacheExpired) {
+         [VSTeamProcessCache]::processes = _getProcesses
+         [VSTeamProcessCache]::timestamp = (Get-Date).Minute
+      }
+
+      foreach ($p in [VSTeamProcessCache]::processes) {
+         if ($p -like "*$WordToComplete*") {
+            $results.Add([CompletionResult]::new($p))
+         }
+      }
+
+      return $results
+   }
+}

Source/Classes/ProcessValidateAttribute.ps1

@@ -0,0 +1,19 @@
+using namespace System.Management.Automation
+
+class ProcessValidateAttribute : ValidateArgumentsAttribute {
+   [void] Validate(
+      [object] $arguments,
+      [EngineIntrinsics] $EngineIntrinsics) {
+
+      if (_hasProcessTemplateCacheExpired) { 
+         [VSTeamProcessCache]::processes = _getProcesses
+         [VSTeamProcessCache]::timestamp = (Get-Date).Minute
+      }
+
+      if (($null -ne [VSTeamProcessCache]::processes) -and (-not ($arguments -in [VSTeamProcessCache]::processes))) {
+         throw [ValidationMetadataException]::new(
+            "'$arguments' is not a valid process. Valid processes are: '" +
+            ([VSTeamProcessCache]::processes -join "', '") + "'")
+      }
+   }
+}

Source/Classes/ProjectCompleter.ps1

@@ -0,0 +1,28 @@
+using namespace System.Collections
+using namespace System.Collections.Generic
+using namespace System.Management.Automation
+
+class ProjectCompleter : IArgumentCompleter {
+   [IEnumerable[CompletionResult]] CompleteArgument(
+      [string] $CommandName,
+      [string] $ParameterName,
+      [string] $WordToComplete,
+      [Language.CommandAst] $CommandAst,
+      [IDictionary] $FakeBoundParameters) {
+
+      $results = [List[CompletionResult]]::new()
+
+      if (_hasProjectCacheExpired) {
+         [VSTeamProjectCache]::projects = _getProjects
+         [VSTeamProjectCache]::timestamp = (Get-Date).Minute
+      }
+
+      foreach ($p in [VSTeamProjectCache]::projects) {
+         if ($p -like "*$WordToComplete*") {
+            $results.Add([CompletionResult]::new($p))
+         }
+      }
+
+      return $results
+   }
+}

Source/Classes/ProjectValidateAttribute.ps1

@@ -0,0 +1,19 @@
+using namespace System.Management.Automation
+
+class ProjectValidateAttribute : ValidateArgumentsAttribute {
+   [void] Validate(
+      [object] $arguments,
+      [EngineIntrinsics] $EngineIntrinsics) {
+
+      if (_hasProjectCacheExpired) {
+         [VSTeamProjectCache]::projects = _getProjects
+         [VSTeamProjectCache]::timestamp = (Get-Date).Minute
+      }
+
+      if (($null -ne [VSTeamProjectCache]::projects) -and (-not ($arguments -in [VSTeamProjectCache]::projects))) {
+         throw [ValidationMetadataException]::new(
+            "'$arguments' is not a valid project. Valid projects are: '" +
+            ([VSTeamProjectCache]::projects -join "', '") + "'")
+      }
+   }
+}

Source/Classes/ReleaseDefinitionCompleter.ps1

@@ -0,0 +1,37 @@
+using namespace System.Collections
+using namespace System.Collections.Generic
+using namespace System.Management.Automation
+
+class ReleaseDefinitionCompleter : IArgumentCompleter {
+   [IEnumerable[CompletionResult]] CompleteArgument(
+      [string] $CommandName,
+      [string] $ParameterName,
+      [string] $WordToComplete,
+      [Language.CommandAst] $CommandAst,
+      [IDictionary] $FakeBoundParameters) {
+
+      $results = [List[CompletionResult]]::new()
+
+      # If the user has explictly added the -ProjectName parameter
+      # to the command use that instead of the default project.
+      $projectName = $FakeBoundParameters['ProjectName']
+
+      # Only use the default project if the ProjectName parameter was
+      # not used
+      if (-not $projectName) {
+         $projectName = _getDefaultProject
+      }
+
+      # If there is no projectName by this point just return a empty
+      # list.
+      if ($projectName) {
+         foreach ($r in (Get-VSTeamReleaseDefinition -ProjectName $projectName)) {
+            if ($r.name -like "*$WordToComplete*") {
+               $results.Add([CompletionResult]::new($r.name))
+            }
+         }
+      }
+
+      return $results
+   }
+}

Source/Classes/TeamQueueCompleter.ps1

@@ -0,0 +1,37 @@
+using namespace System.Collections
+using namespace System.Collections.Generic
+using namespace System.Management.Automation
+
+class TeamQueueCompleter : IArgumentCompleter {
+   [IEnumerable[CompletionResult]] CompleteArgument(
+      [string] $CommandName,
+      [string] $ParameterName,
+      [string] $WordToComplete,
+      [Language.CommandAst] $CommandAst,
+      [IDictionary] $FakeBoundParameters) {
+
+      $results = [List[CompletionResult]]::new()
+
+      # If the user has explictly added the -ProjectName parameter
+      # to the command use that instead of the default project.
+      $projectName = $FakeBoundParameters['ProjectName']
+
+      # Only use the default project if the ProjectName parameter was
+      # not used
+      if (-not $projectName) {
+         $projectName = _getDefaultProject
+      }
+
+      # If there is no projectName by this point just return a empty
+      # list.
+      if ($projectName) {
+         foreach ($q in (Get-VSTeamQueue -ProjectName $projectName)) {
+            if ($q.name -like "*$WordToComplete*") {
+               $results.Add([CompletionResult]::new($q.name))
+            }
+         }
+      }
+
+      return $results
+   }
+}

Source/Classes/UncachedProjectCompleter.ps1

@@ -0,0 +1,29 @@
+using namespace System.Collections
+using namespace System.Collections.Generic
+using namespace System.Management.Automation
+
+class UncachedProjectCompleter : IArgumentCompleter {
+   [IEnumerable[CompletionResult]] CompleteArgument(
+      [string] $CommandName, 
+      [string] $ParameterName, 
+      [string] $WordToComplete,
+      [Language.CommandAst] $CommandAst, 
+      [IDictionary] $FakeBoundParameters) {
+
+      $results = [List[CompletionResult]]::new()
+
+      [VSTeamProjectCache]::projects = _getProjects
+      [VSTeamProjectCache]::timestamp = (Get-Date).Minute
+
+      foreach ($p in [VSTeamProjectCache]::projects) {
+         if ($p -like "*$WordToComplete*" -and $p -match "\s") {
+            $results.Add([CompletionResult]::new("'$p'"))
+         }
+         elseif ($p -like "*$WordToComplete*") {
+            $results.Add([CompletionResult]::new($p))
+         }
+      } 
+
+      return $results
+   }
+}